From: Serge Semin <fancer.lancer@gmail.com>
To: Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <rppt@kernel.org>,
Matthew Wilcox <willy@infradead.org>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
Arnd Bergmann <arnd@arndb.de>,
Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
Aleksandar Rikalo <arikalo@gmail.com>,
Dragan Mladjenovic <dragan.mladjenovic@syrmia.com>,
Chao-ying Fu <cfu@wavecomp.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Yinglu Yang <yangyinglu@loongson.cn>,
Tiezhu Yang <yangtiezhu@loongson.cn>,
Marc Zyngier <maz@kernel.org>,
linux-mips@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 4/7] mips: Optimize max_mapnr init procedure
Date: Wed, 22 Nov 2023 21:24:02 +0300 [thread overview]
Message-ID: <20231122182419.30633-5-fancer.lancer@gmail.com> (raw)
In-Reply-To: <20231122182419.30633-1-fancer.lancer@gmail.com>
max_mapnr defines the upper boundary of the pages space in the system.
Currently in case if HIGHMEM is available it's calculated based on the
upper high memory PFN limit value. Seeing there is a case when it isn't
fully correct let's optimize out the max_mapnr variable initialization
procedure to cover all the handled in the paging_init() method cases:
1. If CPU has DC-aliases, then high memory is unavailable so the PFNs
upper boundary is determined by max_low_pfn.
2. Otherwise if high memory is available, use highend_pfn value
representing the upper high memory PFNs limit.
3. Otherwise no high memory is available so set max_mapnr with the
low-memory upper limit.
Signed-off-by: Serge Semin <fancer.lancer@gmail.com>
---
Since I haven't seen any problem the denoted misconfiguration on my setup
the patch isn't marked as fixes, but as an optimization.
---
arch/mips/mm/init.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/mips/mm/init.c b/arch/mips/mm/init.c
index 6e368a4658b5..b2dce07116e8 100644
--- a/arch/mips/mm/init.c
+++ b/arch/mips/mm/init.c
@@ -421,9 +421,13 @@ void __init paging_init(void)
" %ldk highmem ignored\n",
(highend_pfn - max_low_pfn) << (PAGE_SHIFT - 10));
max_zone_pfns[ZONE_HIGHMEM] = max_low_pfn;
- }
- max_mapnr = highend_pfn ? highend_pfn : max_low_pfn;
+ max_mapnr = max_low_pfn;
+ } else if (highend_pfn) {
+ max_mapnr = highend_pfn;
+ } else {
+ max_mapnr = max_low_pfn;
+ }
#else
max_mapnr = max_low_pfn;
#endif
--
2.42.1
next prev parent reply other threads:[~2023-11-22 18:24 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 18:23 [PATCH 0/7] MIPS: mm: Fix some memory-related issues Serge Semin
2023-11-22 18:23 ` [PATCH 1/7] mips: dmi: Fix early remap on MIPS32 Serge Semin
2023-11-22 19:35 ` Arnd Bergmann
2023-11-23 9:32 ` Serge Semin
2023-11-23 12:13 ` Jiaxun Yang
2023-11-23 12:29 ` Thomas Bogendoerfer
2023-11-23 15:07 ` Jiaxun Yang
2023-11-23 16:07 ` Thomas Bogendoerfer
2023-11-23 17:33 ` Jiaxun Yang
2023-11-24 18:52 ` Serge Semin
2023-11-24 22:03 ` Jiaxun Yang
2023-11-27 16:23 ` Serge Semin
2023-11-27 21:08 ` Jiaxun Yang
2023-11-28 11:34 ` Serge Semin
2023-11-28 15:46 ` Jiaxun Yang
2023-11-30 19:16 ` Serge Semin
2023-12-01 0:13 ` Jiaxun Yang
2023-12-01 14:54 ` Serge Semin
2023-12-01 15:10 ` Jiaxun Yang
2023-12-01 18:26 ` Serge Semin
2023-11-28 12:41 ` Arnd Bergmann
2023-11-28 13:52 ` Serge Semin
2023-11-28 21:59 ` Arnd Bergmann
2023-11-30 19:26 ` Serge Semin
2023-11-24 22:34 ` Jiaxun Yang
2023-11-22 18:24 ` [PATCH 2/7] mips: Fix incorrect max_low_pfn adjustment Serge Semin
2023-11-22 18:24 ` [PATCH 3/7] mips: Fix max_mapnr being uninitialized on early stages Serge Semin
2023-11-22 18:24 ` Serge Semin [this message]
2023-11-22 18:24 ` [PATCH 5/7] mm/mm_init.c: Extend init unavailable range doc info Serge Semin
2023-11-23 10:18 ` Mike Rapoport
2023-11-23 10:42 ` Serge Semin
2023-11-24 8:19 ` Mike Rapoport
2023-11-24 11:18 ` Serge Semin
2023-11-28 7:13 ` Mike Rapoport
2023-11-28 10:51 ` Serge Semin
2023-11-29 6:14 ` Mike Rapoport
2023-11-30 13:30 ` Serge Semin
2023-11-22 18:24 ` [PATCH 6/7] mm/mm_init.c: Append '\n' to the unavailable ranges log-message Serge Semin
2023-11-23 10:06 ` Mike Rapoport
2023-11-22 18:24 ` [PATCH 7/7] mips: Set dump-stack arch description Serge Semin
2023-11-22 18:29 ` [PATCH 0/7] MIPS: mm: Fix some memory-related issues Andrew Morton
2023-11-23 10:12 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231122182419.30633-5-fancer.lancer@gmail.com \
--to=fancer.lancer@gmail.com \
--cc=Alexey.Malahov@baikalelectronics.ru \
--cc=akpm@linux-foundation.org \
--cc=aleksandar.rikalo@syrmia.com \
--cc=arikalo@gmail.com \
--cc=arnd@arndb.de \
--cc=cfu@wavecomp.com \
--cc=dragan.mladjenovic@syrmia.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maz@kernel.org \
--cc=rppt@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=willy@infradead.org \
--cc=yangtiezhu@loongson.cn \
--cc=yangyinglu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox