* [PATCH net] net: ipa: fix one GSI register field width
@ 2023-11-22 21:25 Alex Elder
2023-11-22 22:43 ` Alex Elder
0 siblings, 1 reply; 2+ messages in thread
From: Alex Elder @ 2023-11-22 21:25 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni
Cc: mka, andersson, quic_cpratapa, quic_avuyyuru, quic_jponduru,
quic_subashab, elder, netdev, linux-arm-msm, linux-kernel
The width of the R_LENGTH field of the EV_CH_E_CNTXT_1 GSI register
is 24 bits (not 20 bits) starting with IPA v5.0. Fix this.
Fixes: 627659d542c5 ("net: ipa: add IPA v5.0 GSI register definitions")
Signed-off-by: Alex Elder <elder@linaro.org>
---
drivers/net/ipa/reg/gsi_reg-v5.0.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ipa/reg/gsi_reg-v5.0.c b/drivers/net/ipa/reg/gsi_reg-v5.0.c
index d7b81a36d673b..145eb0bd096d6 100644
--- a/drivers/net/ipa/reg/gsi_reg-v5.0.c
+++ b/drivers/net/ipa/reg/gsi_reg-v5.0.c
@@ -78,7 +78,7 @@ REG_STRIDE_FIELDS(EV_CH_E_CNTXT_0, ev_ch_e_cntxt_0,
0x0001c000 + 0x12000 * GSI_EE_AP, 0x80);
static const u32 reg_ev_ch_e_cntxt_1_fmask[] = {
- [R_LENGTH] = GENMASK(19, 0),
+ [R_LENGTH] = GENMASK(23, 0),
};
REG_STRIDE_FIELDS(EV_CH_E_CNTXT_1, ev_ch_e_cntxt_1,
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] net: ipa: fix one GSI register field width
2023-11-22 21:25 [PATCH net] net: ipa: fix one GSI register field width Alex Elder
@ 2023-11-22 22:43 ` Alex Elder
0 siblings, 0 replies; 2+ messages in thread
From: Alex Elder @ 2023-11-22 22:43 UTC (permalink / raw)
To: davem, edumazet, kuba, pabeni
Cc: mka, andersson, quic_cpratapa, quic_avuyyuru, quic_jponduru,
quic_subashab, elder, netdev, linux-arm-msm, linux-kernel
On 11/22/23 3:25 PM, Alex Elder wrote:
> The width of the R_LENGTH field of the EV_CH_E_CNTXT_1 GSI register
> is 24 bits (not 20 bits) starting with IPA v5.0. Fix this.
>
> Fixes: 627659d542c5 ("net: ipa: add IPA v5.0 GSI register definitions")
All is well on this, but I put the wrong commit hash on the
"Fixes" tag. I'll send an update soon. The correct hash is
faf0678ec8a0.
-Alex
> Signed-off-by: Alex Elder <elder@linaro.org>
> ---
> drivers/net/ipa/reg/gsi_reg-v5.0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ipa/reg/gsi_reg-v5.0.c b/drivers/net/ipa/reg/gsi_reg-v5.0.c
> index d7b81a36d673b..145eb0bd096d6 100644
> --- a/drivers/net/ipa/reg/gsi_reg-v5.0.c
> +++ b/drivers/net/ipa/reg/gsi_reg-v5.0.c
> @@ -78,7 +78,7 @@ REG_STRIDE_FIELDS(EV_CH_E_CNTXT_0, ev_ch_e_cntxt_0,
> 0x0001c000 + 0x12000 * GSI_EE_AP, 0x80);
>
> static const u32 reg_ev_ch_e_cntxt_1_fmask[] = {
> - [R_LENGTH] = GENMASK(19, 0),
> + [R_LENGTH] = GENMASK(23, 0),
> };
>
> REG_STRIDE_FIELDS(EV_CH_E_CNTXT_1, ev_ch_e_cntxt_1,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-11-22 22:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-22 21:25 [PATCH net] net: ipa: fix one GSI register field width Alex Elder
2023-11-22 22:43 ` Alex Elder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox