* [RESEND PATCH v2] leds: syscon: Support 'reg' in addition to 'offset' for register address
@ 2023-11-22 23:07 Rob Herring
2023-11-23 9:12 ` Lee Jones
0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring @ 2023-11-22 23:07 UTC (permalink / raw)
To: Pavel Machek, Lee Jones; +Cc: Linus Walleij, linux-leds, linux-kernel
The register-bit-led binding now also supports 'reg' in addition to
'offset' for the register address. Add support to the driver to get the
address from 'reg'.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Rob Herring <robh@kernel.org>
---
The binding change landed, but v2[1] was never applied. The last
resend[2] may have missed kernel.org addresses.
[1] https://lore.kernel.org/all/20210913192816.1225025-3-robh@kernel.org/
[2] https://lore.kernel.org/all/20231025190619.881090-2-robh@kernel.org/
drivers/leds/leds-syscon.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/leds/leds-syscon.c b/drivers/leds/leds-syscon.c
index 360a376fa738..d633ad519d0c 100644
--- a/drivers/leds/leds-syscon.c
+++ b/drivers/leds/leds-syscon.c
@@ -81,7 +81,8 @@ static int syscon_led_probe(struct platform_device *pdev)
sled->map = map;
- if (of_property_read_u32(np, "offset", &sled->offset))
+ if (of_property_read_u32(np, "reg", &sled->offset) &&
+ of_property_read_u32(np, "offset", &sled->offset))
return -EINVAL;
if (of_property_read_u32(np, "mask", &sled->mask))
return -EINVAL;
--
2.42.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RESEND PATCH v2] leds: syscon: Support 'reg' in addition to 'offset' for register address
2023-11-22 23:07 [RESEND PATCH v2] leds: syscon: Support 'reg' in addition to 'offset' for register address Rob Herring
@ 2023-11-23 9:12 ` Lee Jones
0 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2023-11-23 9:12 UTC (permalink / raw)
To: Rob Herring; +Cc: Pavel Machek, Linus Walleij, linux-leds, linux-kernel
On Wed, 22 Nov 2023, Rob Herring wrote:
> The register-bit-led binding now also supports 'reg' in addition to
> 'offset' for the register address. Add support to the driver to get the
> address from 'reg'.
>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> The binding change landed, but v2[1] was never applied. The last
> resend[2] may have missed kernel.org addresses.
>
> [1] https://lore.kernel.org/all/20210913192816.1225025-3-robh@kernel.org/
> [2] https://lore.kernel.org/all/20231025190619.881090-2-robh@kernel.org/
>
> drivers/leds/leds-syscon.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Looks like I just applied the last one. I'm assuming no additional
changes, but please let me know if that's not the case.
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 4+ messages in thread
* [RESEND PATCH v2] leds: syscon: Support 'reg' in addition to 'offset' for register address
@ 2023-10-25 19:06 Rob Herring
2023-10-25 19:56 ` Linus Walleij
0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring @ 2023-10-25 19:06 UTC (permalink / raw)
To: Pavel Machek, Lee Jones; +Cc: Linus Walleij, linux-leds, linux-kernel
The register-bit-led binding now also supports 'reg' in addition to
'offset' for the register address. Add support to the driver to get the
address from 'reg'.
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: linux-leds@vger.kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
---
The binding change landed, but v2[1] was never applied.
[1] https://lore.kernel.org/all/20210913192816.1225025-3-robh@kernel.org/
drivers/leds/leds-syscon.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/leds/leds-syscon.c b/drivers/leds/leds-syscon.c
index 360a376fa738..d633ad519d0c 100644
--- a/drivers/leds/leds-syscon.c
+++ b/drivers/leds/leds-syscon.c
@@ -81,7 +81,8 @@ static int syscon_led_probe(struct platform_device *pdev)
sled->map = map;
- if (of_property_read_u32(np, "offset", &sled->offset))
+ if (of_property_read_u32(np, "reg", &sled->offset) &&
+ of_property_read_u32(np, "offset", &sled->offset))
return -EINVAL;
if (of_property_read_u32(np, "mask", &sled->mask))
return -EINVAL;
--
2.42.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [RESEND PATCH v2] leds: syscon: Support 'reg' in addition to 'offset' for register address
2023-10-25 19:06 Rob Herring
@ 2023-10-25 19:56 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2023-10-25 19:56 UTC (permalink / raw)
To: Rob Herring; +Cc: Pavel Machek, Lee Jones, linux-leds, linux-kernel
On Wed, Oct 25, 2023 at 9:09 PM Rob Herring <robh@kernel.org> wrote:
> The register-bit-led binding now also supports 'reg' in addition to
> 'offset' for the register address. Add support to the driver to get the
> address from 'reg'.
>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: linux-leds@vger.kernel.org
> Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-11-23 9:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-22 23:07 [RESEND PATCH v2] leds: syscon: Support 'reg' in addition to 'offset' for register address Rob Herring
2023-11-23 9:12 ` Lee Jones
-- strict thread matches above, loose matches on Subject: below --
2023-10-25 19:06 Rob Herring
2023-10-25 19:56 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox