From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E426C5AD4C for ; Thu, 23 Nov 2023 10:39:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344687AbjKWKjI (ORCPT ); Thu, 23 Nov 2023 05:39:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235201AbjKWKjE (ORCPT ); Thu, 23 Nov 2023 05:39:04 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38103D4E for ; Thu, 23 Nov 2023 02:39:11 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 729FDC433C8; Thu, 23 Nov 2023 10:39:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700735950; bh=V8QlEn1tY3YvzwuTK49GT3h8aeTQCvMtxhMSaCgWClk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eqIm9pmM3F/b/jxXxLJElshcaHgClNYbZt3mJ2gBxmGQnlqYalp/F0AIV0SGbwoqS 3xh2DhJnCWYbsf4/bLwj2OmdQq/6rsPhS4XyKAbmcTHSUsWGZ/Do/ygrojCFu6m5f6 mEQB4khLIXD+iTxSU3Na+u+0YmiIKfbVKwYqlakSRDKz8k3S5vKgnvMdJ/IkITLvG3 sWO7jv+kIIQc5vLuks1VZJpk+o+tKNcGh+yxn63IEJEAQgT5ORC6Q481mamyJqeHv9 8FiZIyj7Wyl2gTM+yt3VvPhh/lhiOrmugacrlTbnOc47hy4AOPSvWxGBAdAsEqH/0z qP0pZ98ZZoP8w== Date: Thu, 23 Nov 2023 10:39:06 +0000 From: Lee Jones To: Peter Ujfalusi Cc: tony@atomide.com, robh@kernel.org, wens@csie.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: twl4030-power: Revert to use of_match_device() Message-ID: <20231123103906.GE1184245@google.com> References: <20231029114909.15652-1-peter.ujfalusi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231029114909.15652-1-peter.ujfalusi@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 29 Oct 2023, Peter Ujfalusi wrote: > The core twl chip is probed via i2c and the dev->driver->of_match_table is > NULL, causing the driver to fail to probe. > > This partially reverts commit 1e0c866887f4. > > Fixes: 1e0c866887f4 ("mfd: Use device_get_match_data() in a bunch of drivers") > Signed-off-by: Peter Ujfalusi > --- > drivers/mfd/twl4030-power.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Rob, does this work for you? -- Lee Jones [李琼斯]