From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60A94C5AD4C for ; Thu, 23 Nov 2023 11:58:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345197AbjKWL5z (ORCPT ); Thu, 23 Nov 2023 06:57:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345167AbjKWL5t (ORCPT ); Thu, 23 Nov 2023 06:57:49 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EF649A for ; Thu, 23 Nov 2023 03:57:55 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 014FAC433C8; Thu, 23 Nov 2023 11:57:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700740675; bh=wl9oNNHOLEXop5o0ArpCVRXBXQS6LvZBy1Xs2D72YlQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=RBtfNhqgVf2DOEg6I9Ifs5PmN+q9wsTnGe+qHhbeEJKlV8I3wzrxM4I2f5G51Q6I2 rYG1IMBn7OTW+y1uEZcyfOUd+/AcRqbZEM3uigEqI97iQgNZLWzo1Bb6wlbzq0C9An xoPhMmQyKzAEvEbnekNqT89fst8W1GZVYnGv/8DFHntwaOie+yuRdTkDp9dN7MDmo/ D62Pp6nSt3IQLkaCFiWQT153LIol6TSYcPB5GtiWGB2g5qINJ6P9Y7QELDfkOtUrwh M6CxD1zlgZX6MhtInT6OppoHdLT6VcWlTPaN3dz1G6jojeO1ku1/qcFbqRqy+q2xSf ysgI+NwGKBteA== Date: Thu, 23 Nov 2023 11:57:50 +0000 From: Simon Horman To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= Cc: "David S. Miller" , Eric Dumazet , intel-wired-lan@lists.osuosl.org, Jakub Kicinski , Jesse Brandeburg , Jonathan Cameron , netdev@vger.kernel.org, Paolo Abeni , Tony Nguyen , linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/3] e1000e: Use PCI_EXP_LNKSTA_NLW & FIELD_GET() instead of custom defines/code Message-ID: <20231123115750.GB6339@kernel.org> References: <20231121123428.20907-1-ilpo.jarvinen@linux.intel.com> <20231121123428.20907-3-ilpo.jarvinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231121123428.20907-3-ilpo.jarvinen@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 21, 2023 at 02:34:27PM +0200, Ilpo Järvinen wrote: > e1000e has own copy of PCI Negotiated Link Width field defines. Use the > ones from include/uapi/linux/pci_regs.h instead of the custom ones and > remove the custom ones and convert to FIELD_GET(). > > Suggested-by: Jonathan Cameron > Signed-off-by: Ilpo Järvinen > Reviewed-by: Jonathan Cameron Reviewed-by: Simon Horman