From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 99FDEC61DF7 for ; Thu, 23 Nov 2023 14:34:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345828AbjKWOea (ORCPT ); Thu, 23 Nov 2023 09:34:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345772AbjKWOe2 (ORCPT ); Thu, 23 Nov 2023 09:34:28 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 239FEA4 for ; Thu, 23 Nov 2023 06:34:35 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 79A54C433CA; Thu, 23 Nov 2023 14:34:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700750074; bh=UQZtD3/J3EWnFay8ssfBnsqxH7p2amiDhWgYKfTALAc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jLKhMH45lRed+KJ6STR6/3MFTjtf2H5ttXPl++EXW5oXxN5ZADshoxAH3rjdI/XmN FQmAysB71pY/tMhWGAscAyE6GwlsOv3l8MrcZh2s7HDOoiKl3yd6WwgE6yzzEtzq2L QICQbbCCR4hklr2qYY7tlPIcrUN1WZ0RC/jTdpWho5iFEtxZGG6ZNmv/6vJmazsiPr 93Ps2rZnFk+FlIfxhpPRiY6nMcDv+ZzhNZiZMiPtAQQcnudYPS2xnU6p8AJZl5IL4l Q1ifqstmNG1GZ7qmfmFghsSRc5yaxRHIzCabLf/E7Fy//Yq1bOQu7RWACDuHHCm8Fn xvtLgNDaWA4Kg== Date: Thu, 23 Nov 2023 14:34:28 +0000 From: Simon Horman To: Suraj Jaiswal Cc: Vinod Koul , Bhupesh Sharma , Andy Gross , Bjorn Andersson , Konrad Dybcio , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alexandre Torgue , Jose Abreu , Maxime Coquelin , netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Prasad Sodagudi , Andrew Halaney , kernel@quicinc.com Subject: Re: [PATCH net-next v3 3/3] net: stmmac: Add driver support for DWMAC5 fault IRQ Support Message-ID: <20231123143428.GH6339@kernel.org> References: <62eaaace3713751cb1ecac3163e857737107ca0e.1700737841.git.quic_jsuraj@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <62eaaace3713751cb1ecac3163e857737107ca0e.1700737841.git.quic_jsuraj@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 23, 2023 at 05:08:15PM +0530, Suraj Jaiswal wrote: > Add IRQ support to listen HW fault like ECC,DPP,FSM > fault and print the fault information in the kernel > log. > > Signed-off-by: Suraj Jaiswal ... > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > index 1ffde555da47..bae1704d5f4b 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > @@ -690,9 +690,25 @@ devm_stmmac_probe_config_dt(struct platform_device *pdev, u8 *mac) > #endif /* CONFIG_OF */ > EXPORT_SYMBOL_GPL(devm_stmmac_probe_config_dt); > > +int stmmac_get_fault_intr_config(struct platform_device *pdev, struct stmmac_resources *res) Hi Suraj, stmmac_get_fault_intr_config() appears to only be used in this function. If so it should be static. Also, please consider limiting Networking code to 80 columns wide. static int stmmac_get_fault_intr_config(struct platform_device *pdev, struct stmmac_resources *res) ... -- pw-bot: changes-requested