From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79E36C61D97 for ; Fri, 24 Nov 2023 10:09:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345557AbjKXKJ1 (ORCPT ); Fri, 24 Nov 2023 05:09:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345491AbjKXKJS (ORCPT ); Fri, 24 Nov 2023 05:09:18 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6727D10FF for ; Fri, 24 Nov 2023 02:09:24 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A744FC433C7; Fri, 24 Nov 2023 10:09:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700820564; bh=79vzGQR14LIqiyrjE435UvwcyEj3FQtGfxLgj0DBfG4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cx7VnbdaZkkZAnBiPxYEIx64Y/JvpJGj5krvPkp1ZM+VpWMBH53OuLhAvX2kOKxy+ 8PK0c1nycIfaYd2hb9fAtLgJ65QtsndmtoUTFKSBH71GKd0xPQDwlr+p+oEnRpsp6t cF3I1ATnBHD9kKQbsLizzRB0az1GF6kWc5CAr1ceeE8PGlDde/l/r5vZ69MnfInUU1 2nT0imREu5j8ABcRI5Bw32GgtSvyvbgVox7WEPwo/c9LeHmngVQm+e3G+bbUOrlCR4 bhIpQRiLSefPtf3miU2GQzqAGi1IHFdmF5melWXbu3Jt6d2GQZLhdEmMc28NlpZzqI 5LUKUc8Akpqig== Date: Fri, 24 Nov 2023 15:39:16 +0530 From: Manivannan Sadhasivam To: Qiang Yu Cc: quic_jhugo@quicinc.com, mhi@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, quic_cang@quicinc.com, quic_mrana@quicinc.com, Hemant Kumar , Lazarus Motha Subject: Re: [PATCH v4 4/4] bus: mhi: host: Take irqsave lock after TRE is generated Message-ID: <20231124100916.GB4536@thinkpad> References: <1699939661-7385-1-git-send-email-quic_qianyu@quicinc.com> <1699939661-7385-5-git-send-email-quic_qianyu@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1699939661-7385-5-git-send-email-quic_qianyu@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 14, 2023 at 01:27:41PM +0800, Qiang Yu wrote: > From: Hemant Kumar > > If CONFIG_TRACE_IRQFLAGS is enabled, irq will be enabled once __local_bh_ > enable_ip is called as part of write_unlock_bh. Hence, let's take irqsave "__local_bh_enable_ip" is a function name, so you should not break it. > lock after TRE is generated to avoid running write_unlock_bh when irqsave > lock is held. > I still don't understand this commit message. Where is the write_unlock_bh() being called? - Mani > Signed-off-by: Hemant Kumar > Signed-off-by: Lazarus Motha > Signed-off-by: Qiang Yu > --- > drivers/bus/mhi/host/main.c | 13 +++++-------- > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/drivers/bus/mhi/host/main.c b/drivers/bus/mhi/host/main.c > index 33f27e2..d7abd0b 100644 > --- a/drivers/bus/mhi/host/main.c > +++ b/drivers/bus/mhi/host/main.c > @@ -1128,17 +1128,15 @@ static int mhi_queue(struct mhi_device *mhi_dev, struct mhi_buf_info *buf_info, > if (unlikely(MHI_PM_IN_ERROR_STATE(mhi_cntrl->pm_state))) > return -EIO; > > - read_lock_irqsave(&mhi_cntrl->pm_lock, flags); > - > ret = mhi_is_ring_full(mhi_cntrl, tre_ring); > - if (unlikely(ret)) { > - ret = -EAGAIN; > - goto exit_unlock; > - } > + if (unlikely(ret)) > + return -EAGAIN; > > ret = mhi_gen_tre(mhi_cntrl, mhi_chan, buf_info, mflags); > if (unlikely(ret)) > - goto exit_unlock; > + return ret; > + > + read_lock_irqsave(&mhi_cntrl->pm_lock, flags); > > /* Packet is queued, take a usage ref to exit M3 if necessary > * for host->device buffer, balanced put is done on buffer completion > @@ -1158,7 +1156,6 @@ static int mhi_queue(struct mhi_device *mhi_dev, struct mhi_buf_info *buf_info, > if (dir == DMA_FROM_DEVICE) > mhi_cntrl->runtime_put(mhi_cntrl); > > -exit_unlock: > read_unlock_irqrestore(&mhi_cntrl->pm_lock, flags); > > return ret; > -- > 2.7.4 > > -- மணிவண்ணன் சதாசிவம்