Re: [PATCH v2 10/10] i2c: scx200_acb: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON

jim.cromie
2023-11-26T06:04:11Z

On Fri, Nov 24, 2023 at 3:16 AM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> After removal of the legacy eeprom driver the only remaining I2C
> client device driver supporting I2C_CLASS_SPD is jc42. Because this
> driver also supports I2C_CLASS_HWMON, adapters don't have to
> declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
> It's one step towards getting rid of I2C_CLASS_SPD mid-term.
>
> Series was created supported by Coccinelle and its splitpatch.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>

Acked:

> ---
> drivers/i2c/busses/scx200_acb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/scx200_acb.c b/drivers/i2c/busses/scx200_acb.c
> index 83c1db610..3648382b8 100644
> --- a/drivers/i2c/busses/scx200_acb.c
> +++ b/drivers/i2c/busses/scx200_acb.c
> @@ -427,7 +427,7 @@ static struct scx200_acb_iface *scx200_create_iface(const char *text,
> snprintf(adapter->name, sizeof(adapter->name), "%s ACB%d", text, index);
> adapter->owner = THIS_MODULE;
> adapter->algo = &scx200_acb_algorithm;
> - adapter->class = I2C_CLASS_HWMON | I2C_CLASS_SPD;
> + adapter->class = I2C_CLASS_HWMON;
> adapter->dev.parent = dev;
>
> mutex_init(&iface->mutex);
>