Re: [PATCH v2 08/10] media: netup_unidvb: Don't let i2c adapters declare I2C_CLASS_SPD support if they support I2C_CLASS_HWMON

Hans Verkuil
2023-12-05T08:13:45Z

On 24/11/2023 11:16, Heiner Kallweit wrote:
> After removal of the legacy eeprom driver the only remaining I2C
> client device driver supporting I2C_CLASS_SPD is jc42. Because this
> driver also supports I2C_CLASS_HWMON, adapters don't have to
> declare support for I2C_CLASS_SPD if they support I2C_CLASS_HWMON.
> It's one step towards getting rid of I2C_CLASS_SPD mid-term.
>
> Series was created supported by Coccinelle and its splitpatch.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

Do you want me to take this, or will this go through the i2c subsystem?

Regards,

Hans

>
> ---
> drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c
> index bd38ce444..46676f2c8 100644
> --- a/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c
> +++ b/drivers/media/pci/netup_unidvb/netup_unidvb_i2c.c
> @@ -289,7 +289,7 @@ static const struct i2c_algorithm netup_i2c_algorithm = {
> static const struct i2c_adapter netup_i2c_adapter = {
> .owner = THIS_MODULE,
> .name = NETUP_UNIDVB_NAME,
> - .class = I2C_CLASS_HWMON | I2C_CLASS_SPD,
> + .class = I2C_CLASS_HWMON,
> .algo = &netup_i2c_algorithm,
> };
>
>
>