From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH v2 2/6] debugfs: annotate debugfs handlers vs. removal with lockdep
Date: Sat, 25 Nov 2023 14:48:34 +0000 [thread overview]
Message-ID: <2023112530-eraser-glare-44b2@gregkh> (raw)
In-Reply-To: <20231124172522.0442774abc66.Ia70a49792c448867fd61b0234e1da507b0f75086@changeid>
On Fri, Nov 24, 2023 at 05:25:25PM +0100, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> When you take a lock in a debugfs handler but also try
> to remove the debugfs file under that lock, things can
> deadlock since the removal has to wait for all users
> to finish.
>
> Add lockdep annotations in debugfs_file_get()/_put()
> to catch such issues.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2023-11-25 14:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-24 16:25 [PATCH v2 0/6] fixes for debugfs/wireless locking issue Johannes Berg
2023-11-24 16:25 ` [PATCH v2 1/6] debugfs: fix automount d_fsdata usage Johannes Berg
2023-11-25 14:48 ` Greg Kroah-Hartman
2023-11-25 18:31 ` Johannes Berg
2023-11-25 19:29 ` Greg Kroah-Hartman
2023-11-24 16:25 ` [PATCH v2 2/6] debugfs: annotate debugfs handlers vs. removal with lockdep Johannes Berg
2023-11-25 14:48 ` Greg Kroah-Hartman [this message]
2023-11-24 16:25 ` [PATCH v2 3/6] debugfs: add API to allow debugfs operations cancellation Johannes Berg
2023-11-25 14:48 ` Greg Kroah-Hartman
2023-11-24 16:25 ` [PATCH v2 4/6] wifi: cfg80211: add locked debugfs wrappers Johannes Berg
2023-11-24 16:25 ` [PATCH v2 5/6] wifi: mac80211: use wiphy locked debugfs helpers for agg_status Johannes Berg
2023-11-24 16:25 ` [PATCH v2 6/6] wifi: mac80211: use wiphy locked debugfs for sdata/link Johannes Berg
2023-11-28 15:48 ` [PATCH v2 0/6] fixes for debugfs/wireless locking issue Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023112530-eraser-glare-44b2@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox