* Re: [PATCH 5.10 000/187] 5.10.202-rc3 review
2023-11-26 15:46 [PATCH 5.10 000/187] 5.10.202-rc3 review Greg Kroah-Hartman
@ 2023-11-26 16:22 ` Guenter Roeck
2023-11-27 11:45 ` [PATCH 5.10] interconnect: qcom: Add support for mask-based BCMs djakov
2023-11-26 18:23 ` [PATCH 5.10 000/187] 5.10.202-rc3 review Guenter Roeck
` (5 subsequent siblings)
6 siblings, 1 reply; 18+ messages in thread
From: Guenter Roeck @ 2023-11-26 16:22 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, allen.lkml
On 11/26/23 07:46, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.202 release.
> There are 187 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Tue, 28 Nov 2023 15:43:06 +0000.
> Anything received after that time might be too late.
>
A quick check with -rc3 shows for arm:allmodconfig and arm64:allmodconfig:
CC [M] drivers/interconnect/qcom/sc7180.o
drivers/interconnect/qcom/sc7180.c:158:10: error: 'struct qcom_icc_bcm' has no member named 'enable_mask'
158 | .enable_mask = BIT(3),
| ^~~~~~~~~~~
Inherited from the previous release. Introduced with commit 362f0241dbe9
("interconnect: qcom: sc7180: Set ACV enable_mask").
Guenter
^ permalink raw reply [flat|nested] 18+ messages in thread* [PATCH 5.10] interconnect: qcom: Add support for mask-based BCMs
2023-11-26 16:22 ` Guenter Roeck
@ 2023-11-27 11:45 ` djakov
2023-11-27 12:40 ` Greg KH
0 siblings, 1 reply; 18+ messages in thread
From: djakov @ 2023-11-27 11:45 UTC (permalink / raw)
To: linux, sam, gregkh
Cc: akpm, allen.lkml, conor, f.fainelli, jonathanh, linux-kernel,
lkft-triage, patches, patches, pavel, rwarsow, shuah, srw, stable,
sudipm.mukherjee, torvalds, djakov
From: Georgi Djakov <djakov@kernel.org>
From: Mike Tipton <mdtipton@codeaurora.org>
[ Upstream commit d8630f050d3fd2079f8617dd6c00c6509109c755 ]
Some BCMs aren't directly associated with the data path (i.e. ACV) and
therefore don't communicate using BW. Instead, they are simply
enabled/disabled with a simple bit mask. Add support for these.
Origin commit retrieved from:
https://git.codelinaro.org/clo/la/kernel/msm-5.15/-/commit/2d1573e0206998151b342e6b52a4c0f7234d7e36
Signed-off-by: Mike Tipton <mdtipton@codeaurora.org>
[narmstrong: removed copyright change from original commit]
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/20230619-topic-sm8550-upstream-interconnect-mask-vote-v2-1-709474b151cc@linaro.org
Fixes: fafc114a468e ("interconnect: qcom: Add SM8450 interconnect provider driver")
Fixes: 2d1f95ab9feb ("interconnect: qcom: Add SC7180 interconnect provider driver")
Signed-off-by: Georgi Djakov <djakov@kernel.org>
---
There is a build error reported in the 5.10.201 stable tree (arm64 allmodconfig),
which is caused by a patch that has a dependency we missed to backport. This is
the missing patch that we need to get into 5.10.202 to fix the build failure.
Thanks to Guenter and Sam for reporting that!
drivers/interconnect/qcom/bcm-voter.c | 5 +++++
drivers/interconnect/qcom/icc-rpmh.h | 2 ++
2 files changed, 7 insertions(+)
diff --git a/drivers/interconnect/qcom/bcm-voter.c b/drivers/interconnect/qcom/bcm-voter.c
index 3c0809095a31..320e418cf753 100644
--- a/drivers/interconnect/qcom/bcm-voter.c
+++ b/drivers/interconnect/qcom/bcm-voter.c
@@ -90,6 +90,11 @@ static void bcm_aggregate(struct qcom_icc_bcm *bcm)
temp = agg_peak[bucket] * bcm->vote_scale;
bcm->vote_y[bucket] = bcm_div(temp, bcm->aux_data.unit);
+
+ if (bcm->enable_mask && (bcm->vote_x[bucket] || bcm->vote_y[bucket])) {
+ bcm->vote_x[bucket] = 0;
+ bcm->vote_y[bucket] = bcm->enable_mask;
+ }
}
if (bcm->keepalive && bcm->vote_x[QCOM_ICC_BUCKET_AMC] == 0 &&
diff --git a/drivers/interconnect/qcom/icc-rpmh.h b/drivers/interconnect/qcom/icc-rpmh.h
index e5f61ab989e7..029a350c2884 100644
--- a/drivers/interconnect/qcom/icc-rpmh.h
+++ b/drivers/interconnect/qcom/icc-rpmh.h
@@ -81,6 +81,7 @@ struct qcom_icc_node {
* @vote_x: aggregated threshold values, represents sum_bw when @type is bw bcm
* @vote_y: aggregated threshold values, represents peak_bw when @type is bw bcm
* @vote_scale: scaling factor for vote_x and vote_y
+ * @enable_mask: optional mask to send as vote instead of vote_x/vote_y
* @dirty: flag used to indicate whether the bcm needs to be committed
* @keepalive: flag used to indicate whether a keepalive is required
* @aux_data: auxiliary data used when calculating threshold values and
@@ -97,6 +98,7 @@ struct qcom_icc_bcm {
u64 vote_x[QCOM_ICC_NUM_BUCKETS];
u64 vote_y[QCOM_ICC_NUM_BUCKETS];
u64 vote_scale;
+ u32 enable_mask;
bool dirty;
bool keepalive;
struct bcm_db aux_data;
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH 5.10] interconnect: qcom: Add support for mask-based BCMs
2023-11-27 11:45 ` [PATCH 5.10] interconnect: qcom: Add support for mask-based BCMs djakov
@ 2023-11-27 12:40 ` Greg KH
0 siblings, 0 replies; 18+ messages in thread
From: Greg KH @ 2023-11-27 12:40 UTC (permalink / raw)
To: djakov
Cc: linux, sam, akpm, allen.lkml, conor, f.fainelli, jonathanh,
linux-kernel, lkft-triage, patches, patches, pavel, rwarsow,
shuah, srw, stable, sudipm.mukherjee, torvalds
On Mon, Nov 27, 2023 at 01:45:51PM +0200, djakov@kernel.org wrote:
> From: Georgi Djakov <djakov@kernel.org>
>
> From: Mike Tipton <mdtipton@codeaurora.org>
>
> [ Upstream commit d8630f050d3fd2079f8617dd6c00c6509109c755 ]
>
> Some BCMs aren't directly associated with the data path (i.e. ACV) and
> therefore don't communicate using BW. Instead, they are simply
> enabled/disabled with a simple bit mask. Add support for these.
>
> Origin commit retrieved from:
> https://git.codelinaro.org/clo/la/kernel/msm-5.15/-/commit/2d1573e0206998151b342e6b52a4c0f7234d7e36
>
> Signed-off-by: Mike Tipton <mdtipton@codeaurora.org>
> [narmstrong: removed copyright change from original commit]
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> Link: https://lore.kernel.org/r/20230619-topic-sm8550-upstream-interconnect-mask-vote-v2-1-709474b151cc@linaro.org
> Fixes: fafc114a468e ("interconnect: qcom: Add SM8450 interconnect provider driver")
> Fixes: 2d1f95ab9feb ("interconnect: qcom: Add SC7180 interconnect provider driver")
> Signed-off-by: Georgi Djakov <djakov@kernel.org>
> ---
>
> There is a build error reported in the 5.10.201 stable tree (arm64 allmodconfig),
> which is caused by a patch that has a dependency we missed to backport. This is
> the missing patch that we need to get into 5.10.202 to fix the build failure.
> Thanks to Guenter and Sam for reporting that!
>
> drivers/interconnect/qcom/bcm-voter.c | 5 +++++
> drivers/interconnect/qcom/icc-rpmh.h | 2 ++
> 2 files changed, 7 insertions(+)
Now queued up, thanks.
greg ik-h
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 5.10 000/187] 5.10.202-rc3 review
2023-11-26 15:46 [PATCH 5.10 000/187] 5.10.202-rc3 review Greg Kroah-Hartman
2023-11-26 16:22 ` Guenter Roeck
@ 2023-11-26 18:23 ` Guenter Roeck
2023-11-27 12:40 ` Greg Kroah-Hartman
2023-11-27 3:51 ` Florian Fainelli
` (4 subsequent siblings)
6 siblings, 1 reply; 18+ messages in thread
From: Guenter Roeck @ 2023-11-26 18:23 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, allen.lkml
On 11/26/23 07:46, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.202 release.
> There are 187 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Tue, 28 Nov 2023 15:43:06 +0000.
> Anything received after that time might be too late.
>
For v5.10.201-188-g2f84e268b78b (5.10.202-rc3):
s390:defconfig, s390:allmodconfig, s390:debug_defconfig:
drivers/s390/crypto/ap_bus.c: In function 'ap_bus_force_rescan':
drivers/s390/crypto/ap_bus.c:791:28: error: 'ap_scan_bus_count' undeclared
$ git grep ap_scan_bus_count
drivers/s390/crypto/ap_bus.c: if (atomic64_read(&ap_scan_bus_count) <= 0)
$ git blame drivers/s390/crypto/ap_bus.c |& grep ap_scan_bus_count
467f51fb3ab6e (Harald Freudenberger 2023-10-23 09:57:10 +0200 791) if (atomic64_read(&ap_scan_bus_count) <= 0)
which is:
467f51fb3ab6 s390/ap: fix AP bus crash on early config change callback invocation
Guenter
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 5.10 000/187] 5.10.202-rc3 review
2023-11-26 18:23 ` [PATCH 5.10 000/187] 5.10.202-rc3 review Guenter Roeck
@ 2023-11-27 12:40 ` Greg Kroah-Hartman
0 siblings, 0 replies; 18+ messages in thread
From: Greg Kroah-Hartman @ 2023-11-27 12:40 UTC (permalink / raw)
To: Guenter Roeck
Cc: stable, patches, linux-kernel, torvalds, akpm, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, allen.lkml
On Sun, Nov 26, 2023 at 10:23:24AM -0800, Guenter Roeck wrote:
> On 11/26/23 07:46, Greg Kroah-Hartman wrote:
> > This is the start of the stable review cycle for the 5.10.202 release.
> > There are 187 patches in this series, all will be posted as a response
> > to this one. If anyone has any issues with these being applied, please
> > let me know.
> >
> > Responses should be made by Tue, 28 Nov 2023 15:43:06 +0000.
> > Anything received after that time might be too late.
> >
>
> For v5.10.201-188-g2f84e268b78b (5.10.202-rc3):
>
> s390:defconfig, s390:allmodconfig, s390:debug_defconfig:
>
> drivers/s390/crypto/ap_bus.c: In function 'ap_bus_force_rescan':
> drivers/s390/crypto/ap_bus.c:791:28: error: 'ap_scan_bus_count' undeclared
>
> $ git grep ap_scan_bus_count
> drivers/s390/crypto/ap_bus.c: if (atomic64_read(&ap_scan_bus_count) <= 0)
> $ git blame drivers/s390/crypto/ap_bus.c |& grep ap_scan_bus_count
> 467f51fb3ab6e (Harald Freudenberger 2023-10-23 09:57:10 +0200 791) if (atomic64_read(&ap_scan_bus_count) <= 0)
>
> which is:
>
> 467f51fb3ab6 s390/ap: fix AP bus crash on early config change callback invocation
Now dropped, thanks.
greg k-h
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 5.10 000/187] 5.10.202-rc3 review
2023-11-26 15:46 [PATCH 5.10 000/187] 5.10.202-rc3 review Greg Kroah-Hartman
2023-11-26 16:22 ` Guenter Roeck
2023-11-26 18:23 ` [PATCH 5.10 000/187] 5.10.202-rc3 review Guenter Roeck
@ 2023-11-27 3:51 ` Florian Fainelli
2023-11-27 21:25 ` Pavel Machek
` (3 subsequent siblings)
6 siblings, 0 replies; 18+ messages in thread
From: Florian Fainelli @ 2023-11-27 3:51 UTC (permalink / raw)
To: Greg Kroah-Hartman, stable
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, jonathanh, sudipm.mukherjee, srw, rwarsow,
conor, allen.lkml
On 11/26/2023 7:46 AM, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.202 release.
> There are 187 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Tue, 28 Nov 2023 15:43:06 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.202-rc3.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
On ARCH_BRCMSTB using 32-bit and 64-bit ARM kernels, build tested on
BMIPS_GENERIC:
Tested-by: Florian Fainelli <florian.fainelli@broadcom.com>
--
Florian
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 5.10 000/187] 5.10.202-rc3 review
2023-11-26 15:46 [PATCH 5.10 000/187] 5.10.202-rc3 review Greg Kroah-Hartman
` (2 preceding siblings ...)
2023-11-27 3:51 ` Florian Fainelli
@ 2023-11-27 21:25 ` Pavel Machek
2023-11-28 6:56 ` Dominique Martinet
2023-11-28 10:42 ` Richard Fitzgerald
2023-11-27 23:27 ` Jon Hunter
` (2 subsequent siblings)
6 siblings, 2 replies; 18+ messages in thread
From: Pavel Machek @ 2023-11-27 21:25 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, maz,
andy.shevchenko, brgl, wangyouwan, jani.nikula, rf, ilpo.jarvinen,
dan.carpenter
[-- Attachment #1: Type: text/plain, Size: 1785 bytes --]
Hi!
> This is the start of the stable review cycle for the 5.10.202 release.
> There are 187 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
> Marc Zyngier <maz@kernel.org>
> gpio: Don't fiddle with irqchips marked as immutable
This is attempt to move people to new API, which will cause warning
for existing users. "chip_warn(gc, "not an immutable chip, please
consider fixing it!\n");". It is marked as dependency of another
patch, but I'm not sure we should be doing this in stable.
> youwan Wang <wangyouwan@126.com>
> Bluetooth: btusb: Add date->evt_skb is NULL check
Could someone double check this? If we hit the null check, we'll be
returning success, but it sounds like an error case.
> Jani Nikula <jani.nikula@intel.com>
> drm/msm/dp: skip validity check for DP CTS EDID checksum
This is preparation for future cleanup, do we need it?
> Richard Fitzgerald <rf@opensource.cirrus.com>
> ASoC: soc-card: Add storage for PCI SSID
This adds infrastructure for white/blacklisting, but I don't see an
user of that in 5.10 (or 6.1).
> Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> media: cobalt: Use FIELD_GET() to extract Link Width
Cleanup, but not a bugfix.
> Dan Carpenter <dan.carpenter@linaro.org>
> SUNRPC: Add an IS_ERR() check back to where it was
According to changelog, this is only needed with commit 25cf32ad5dba
("SUNRPC: Handle allocation failure in rpc_new_task()") in tree, and
we don't have that in 5.10.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 5.10 000/187] 5.10.202-rc3 review
2023-11-27 21:25 ` Pavel Machek
@ 2023-11-28 6:56 ` Dominique Martinet
2023-11-28 20:43 ` Pavel Machek
2023-11-28 10:42 ` Richard Fitzgerald
1 sibling, 1 reply; 18+ messages in thread
From: Dominique Martinet @ 2023-11-28 6:56 UTC (permalink / raw)
To: Pavel Machek, youwan Wang, Luiz Augusto von Dentz
Cc: Greg Kroah-Hartman, stable, patches, linux-kernel, torvalds, akpm,
linux, shuah, patches, lkft-triage, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, maz,
andy.shevchenko, brgl, wangyouwan, jani.nikula, rf, ilpo.jarvinen,
dan.carpenter
Pavel Machek wrote on Mon, Nov 27, 2023 at 10:25:46PM +0100:
> > Marc Zyngier <maz@kernel.org>
> > gpio: Don't fiddle with irqchips marked as immutable
>
> This is attempt to move people to new API, which will cause warning
> for existing users. "chip_warn(gc, "not an immutable chip, please
> consider fixing it!\n");". It is marked as dependency of another
> patch, but I'm not sure we should be doing this in stable.
And this actually did make some tests fail on tegra (other branch on
this thread), it's probably safer to drop the gpio patches unless we're
prepared to backport all the "make immutable" patches as well.
(I don't see why it'd be required for dc3115e6c5d9 either but I didn't
look all that close)
> > youwan Wang <wangyouwan@126.com>
> > Bluetooth: btusb: Add date->evt_skb is NULL check
>
> Could someone double check this? If we hit the null check, we'll be
> returning success, but it sounds like an error case.
I agree with your analysis; added Youwan and Luiz in recipients.
btusb_mtk_hci_wmt_sync will return 0 if the skb is null here -- should
this be setting err = -EINVAL or something?
> > Jani Nikula <jani.nikula@intel.com>
> > drm/msm/dp: skip validity check for DP CTS EDID checksum
>
> This is preparation for future cleanup, do we need it?
(For cleanup patches I'd say if it makes future backports easier it
doesn't hurt to take them)
--
Dominique Martinet | Asmadeus
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 5.10 000/187] 5.10.202-rc3 review
2023-11-28 6:56 ` Dominique Martinet
@ 2023-11-28 20:43 ` Pavel Machek
0 siblings, 0 replies; 18+ messages in thread
From: Pavel Machek @ 2023-11-28 20:43 UTC (permalink / raw)
To: Dominique Martinet
Cc: Pavel Machek, youwan Wang, Luiz Augusto von Dentz,
Greg Kroah-Hartman, stable, patches, linux-kernel, torvalds, akpm,
linux, shuah, patches, lkft-triage, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, maz,
andy.shevchenko, brgl, jani.nikula, rf, ilpo.jarvinen,
dan.carpenter
[-- Attachment #1: Type: text/plain, Size: 665 bytes --]
Hi!
> > > Jani Nikula <jani.nikula@intel.com>
> > > drm/msm/dp: skip validity check for DP CTS EDID checksum
> >
> > This is preparation for future cleanup, do we need it?
>
> (For cleanup patches I'd say if it makes future backports easier it
> doesn't hurt to take them)
Well, stable-kernel-rules says we only take fixes for "serious"
bugs. Reality is different, but I'd really like reality and
documentation to match.
Thanks for reviewing the other comments!
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 5.10 000/187] 5.10.202-rc3 review
2023-11-27 21:25 ` Pavel Machek
2023-11-28 6:56 ` Dominique Martinet
@ 2023-11-28 10:42 ` Richard Fitzgerald
2023-11-28 20:40 ` Pavel Machek
1 sibling, 1 reply; 18+ messages in thread
From: Richard Fitzgerald @ 2023-11-28 10:42 UTC (permalink / raw)
To: Pavel Machek, Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, jonathanh, f.fainelli, sudipm.mukherjee,
srw, rwarsow, conor, allen.lkml, maz, andy.shevchenko, brgl,
wangyouwan, jani.nikula, ilpo.jarvinen, dan.carpenter
On 27/11/2023 21:25, Pavel Machek wrote:
>
>> Richard Fitzgerald <rf@opensource.cirrus.com>
>> ASoC: soc-card: Add storage for PCI SSID
>
The driver that depends on this only went into the kernel at v6.4.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 5.10 000/187] 5.10.202-rc3 review
2023-11-28 10:42 ` Richard Fitzgerald
@ 2023-11-28 20:40 ` Pavel Machek
2023-11-29 11:35 ` Richard Fitzgerald
0 siblings, 1 reply; 18+ messages in thread
From: Pavel Machek @ 2023-11-28 20:40 UTC (permalink / raw)
To: Richard Fitzgerald
Cc: Pavel Machek, Greg Kroah-Hartman, stable, patches, linux-kernel,
torvalds, akpm, linux, shuah, patches, lkft-triage, jonathanh,
f.fainelli, sudipm.mukherjee, srw, rwarsow, conor, allen.lkml,
maz, andy.shevchenko, brgl, wangyouwan, jani.nikula,
ilpo.jarvinen, dan.carpenter
[-- Attachment #1: Type: text/plain, Size: 533 bytes --]
On Tue 2023-11-28 10:42:51, Richard Fitzgerald wrote:
> On 27/11/2023 21:25, Pavel Machek wrote:
> >
> > > Richard Fitzgerald <rf@opensource.cirrus.com>
> > > ASoC: soc-card: Add storage for PCI SSID
> >
>
> The driver that depends on this only went into the kernel at v6.4.
Thanks. So it would be good to drop this from 5.10 and 6.1.
Best regards,
Pavel
--
DENX Software Engineering GmbH, Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 5.10 000/187] 5.10.202-rc3 review
2023-11-28 20:40 ` Pavel Machek
@ 2023-11-29 11:35 ` Richard Fitzgerald
0 siblings, 0 replies; 18+ messages in thread
From: Richard Fitzgerald @ 2023-11-29 11:35 UTC (permalink / raw)
To: Pavel Machek
Cc: Greg Kroah-Hartman, stable, patches, linux-kernel, torvalds, akpm,
linux, shuah, patches, lkft-triage, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, maz,
andy.shevchenko, brgl, wangyouwan, jani.nikula, ilpo.jarvinen,
dan.carpenter, Pierre-Louis Bossart, Mark Brown
On 28/11/2023 20:40, Pavel Machek wrote:
> On Tue 2023-11-28 10:42:51, Richard Fitzgerald wrote:
>> On 27/11/2023 21:25, Pavel Machek wrote:
>>>
>>>> Richard Fitzgerald <rf@opensource.cirrus.com>
>>>> ASoC: soc-card: Add storage for PCI SSID
>>>
>>
>> The driver that depends on this only went into the kernel at v6.4.
>
> Thanks. So it would be good to drop this from 5.10 and 6.1.
>
> Best regards,
> Pavel
I don't have any need for this to go into 5.10 and 6.1.
But I've added Mark Brown (for ASoC) and Pierre-Louis Bossart (Intel,
there were some patches to Intel drivers in the set this patch was
cherry-picked from) so they can comment if they disagree.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 5.10 000/187] 5.10.202-rc3 review
2023-11-26 15:46 [PATCH 5.10 000/187] 5.10.202-rc3 review Greg Kroah-Hartman
` (3 preceding siblings ...)
2023-11-27 21:25 ` Pavel Machek
@ 2023-11-27 23:27 ` Jon Hunter
2023-11-27 23:37 ` Jon Hunter
2023-11-28 2:52 ` Guenter Roeck
2023-11-28 9:30 ` Naresh Kamboju
6 siblings, 1 reply; 18+ messages in thread
From: Jon Hunter @ 2023-11-27 23:27 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Greg Kroah-Hartman, patches, linux-kernel, torvalds, akpm, linux,
shuah, patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, linux-tegra,
stable
On Sun, 26 Nov 2023 15:46:55 +0000, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.202 release.
> There are 187 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Tue, 28 Nov 2023 15:43:06 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.202-rc3.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
Failures detected for Tegra ...
Test results for stable-v5.10:
10 builds: 10 pass, 0 fail
26 boots: 26 pass, 0 fail
68 tests: 67 pass, 1 fail
Linux version: 5.10.202-rc3-g80dc4301c91e
Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000,
tegra20-ventana, tegra210-p2371-2180,
tegra210-p3450-0000, tegra30-cardhu-a04
Test failures: tegra194-p2972-0000: boot.py
Jon
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 5.10 000/187] 5.10.202-rc3 review
2023-11-27 23:27 ` Jon Hunter
@ 2023-11-27 23:37 ` Jon Hunter
2023-11-28 9:42 ` Greg Kroah-Hartman
0 siblings, 1 reply; 18+ messages in thread
From: Jon Hunter @ 2023-11-27 23:37 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, f.fainelli, sudipm.mukherjee, srw, rwarsow,
conor, allen.lkml, linux-tegra, stable
On 27/11/2023 23:27, Jon Hunter wrote:
> On Sun, 26 Nov 2023 15:46:55 +0000, Greg Kroah-Hartman wrote:
>> This is the start of the stable review cycle for the 5.10.202 release.
>> There are 187 patches in this series, all will be posted as a response
>> to this one. If anyone has any issues with these being applied, please
>> let me know.
>>
>> Responses should be made by Tue, 28 Nov 2023 15:43:06 +0000.
>> Anything received after that time might be too late.
>>
>> The whole patch series can be found in one patch at:
>> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.202-rc3.gz
>> or in the git tree and branch at:
>> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
>> and the diffstat can be found below.
>>
>> thanks,
>>
>> greg k-h
>
> Failures detected for Tegra ...
>
> Test results for stable-v5.10:
> 10 builds: 10 pass, 0 fail
> 26 boots: 26 pass, 0 fail
> 68 tests: 67 pass, 1 fail
>
> Linux version: 5.10.202-rc3-g80dc4301c91e
> Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
> tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000,
> tegra20-ventana, tegra210-p2371-2180,
> tegra210-p3450-0000, tegra30-cardhu-a04
>
> Test failures: tegra194-p2972-0000: boot.py
After commit the commit "gpio: Don't fiddle with irqchips marked as
immutable" added, we observe the following warnings and is causing a
test to fail ...
WARNING KERN gpio gpiochip0: (max77620-gpio): not an immutable chip,
please consider fixing it!
WARNING KERN gpio gpiochip1: (tegra194-gpio): not an immutable chip,
please consider fixing it!
WARNING KERN gpio gpiochip2: (tegra194-gpio-aon): not an immutable
chip, please consider fixing it!
The following upstream changes fix these ...
7d1aa08aff06 gpio: tegra: Convert to immutable irq chip
bba00555ede7 gpio: tegra186: Make the irqchip immutable
7f42aa7b008c gpio: max77620: Make the irqchip immutable
There are quite a few other drivers that were updated in a similar way,
so the above only fix the ones we observe on Tegra.
Jon
--
nvpublic
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 5.10 000/187] 5.10.202-rc3 review
2023-11-27 23:37 ` Jon Hunter
@ 2023-11-28 9:42 ` Greg Kroah-Hartman
0 siblings, 0 replies; 18+ messages in thread
From: Greg Kroah-Hartman @ 2023-11-28 9:42 UTC (permalink / raw)
To: Jon Hunter
Cc: patches, linux-kernel, torvalds, akpm, linux, shuah, patches,
lkft-triage, pavel, f.fainelli, sudipm.mukherjee, srw, rwarsow,
conor, allen.lkml, linux-tegra, stable
On Mon, Nov 27, 2023 at 11:37:17PM +0000, Jon Hunter wrote:
>
> On 27/11/2023 23:27, Jon Hunter wrote:
> > On Sun, 26 Nov 2023 15:46:55 +0000, Greg Kroah-Hartman wrote:
> > > This is the start of the stable review cycle for the 5.10.202 release.
> > > There are 187 patches in this series, all will be posted as a response
> > > to this one. If anyone has any issues with these being applied, please
> > > let me know.
> > >
> > > Responses should be made by Tue, 28 Nov 2023 15:43:06 +0000.
> > > Anything received after that time might be too late.
> > >
> > > The whole patch series can be found in one patch at:
> > > https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.202-rc3.gz
> > > or in the git tree and branch at:
> > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> > > and the diffstat can be found below.
> > >
> > > thanks,
> > >
> > > greg k-h
> >
> > Failures detected for Tegra ...
> >
> > Test results for stable-v5.10:
> > 10 builds: 10 pass, 0 fail
> > 26 boots: 26 pass, 0 fail
> > 68 tests: 67 pass, 1 fail
> >
> > Linux version: 5.10.202-rc3-g80dc4301c91e
> > Boards tested: tegra124-jetson-tk1, tegra186-p2771-0000,
> > tegra194-p2972-0000, tegra194-p3509-0000+p3668-0000,
> > tegra20-ventana, tegra210-p2371-2180,
> > tegra210-p3450-0000, tegra30-cardhu-a04
> >
> > Test failures: tegra194-p2972-0000: boot.py
>
>
> After commit the commit "gpio: Don't fiddle with irqchips marked as
> immutable" added, we observe the following warnings and is causing a test to
> fail ...
>
> WARNING KERN gpio gpiochip0: (max77620-gpio): not an immutable chip, please
> consider fixing it!
> WARNING KERN gpio gpiochip1: (tegra194-gpio): not an immutable chip, please
> consider fixing it!
> WARNING KERN gpio gpiochip2: (tegra194-gpio-aon): not an immutable chip,
> please consider fixing it!
>
> The following upstream changes fix these ...
>
> 7d1aa08aff06 gpio: tegra: Convert to immutable irq chip
> bba00555ede7 gpio: tegra186: Make the irqchip immutable
> 7f42aa7b008c gpio: max77620: Make the irqchip immutable
>
> There are quite a few other drivers that were updated in a similar way, so
> the above only fix the ones we observe on Tegra.
Ick, those patches snuck back in again, and they aren't even needed in
these branches as I fixed up the real fix that they were dependencies of.
I'll go drop them from 5.10.y and 5.15.y now, thanks!
greg k-h
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 5.10 000/187] 5.10.202-rc3 review
2023-11-26 15:46 [PATCH 5.10 000/187] 5.10.202-rc3 review Greg Kroah-Hartman
` (4 preceding siblings ...)
2023-11-27 23:27 ` Jon Hunter
@ 2023-11-28 2:52 ` Guenter Roeck
2023-11-28 9:30 ` Naresh Kamboju
6 siblings, 0 replies; 18+ messages in thread
From: Guenter Roeck @ 2023-11-28 2:52 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, shuah, patches,
lkft-triage, pavel, jonathanh, f.fainelli, sudipm.mukherjee, srw,
rwarsow, conor, allen.lkml
On Sun, Nov 26, 2023 at 03:46:55PM +0000, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 5.10.202 release.
> There are 187 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Tue, 28 Nov 2023 15:43:06 +0000.
> Anything received after that time might be too late.
>
For v5.10.201-188-g80dc4301c91e:
Build results:
total: 157 pass: 157 fail: 0
Qemu test results:
total: 495 pass: 495 fail: 0
Tested-by: Guenter Roeck <linux@roeck-us.net>
Guenter
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [PATCH 5.10 000/187] 5.10.202-rc3 review
2023-11-26 15:46 [PATCH 5.10 000/187] 5.10.202-rc3 review Greg Kroah-Hartman
` (5 preceding siblings ...)
2023-11-28 2:52 ` Guenter Roeck
@ 2023-11-28 9:30 ` Naresh Kamboju
6 siblings, 0 replies; 18+ messages in thread
From: Naresh Kamboju @ 2023-11-28 9:30 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: stable, patches, linux-kernel, torvalds, akpm, linux, shuah,
patches, lkft-triage, pavel, jonathanh, f.fainelli,
sudipm.mukherjee, srw, rwarsow, conor, allen.lkml, Marc Zyngier,
open list:GPIO SUBSYSTEM
On Sun, 26 Nov 2023 at 21:17, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
>
> This is the start of the stable review cycle for the 5.10.202 release.
> There are 187 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses should be made by Tue, 28 Nov 2023 15:43:06 +0000.
> Anything received after that time might be too late.
>
> The whole patch series can be found in one patch at:
> https://www.kernel.org/pub/linux/kernel/v5.x/stable-review/patch-5.10.202-rc3.gz
> or in the git tree and branch at:
> git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-5.10.y
> and the diffstat can be found below.
>
> thanks,
>
> greg k-h
Results from Linaro's test farm.
No regressions on arm64, arm, x86_64, and i386.
Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
NOTE:
As others reported on gpio warning while booting arm and arm64 noticed.
[ 0.466552] gpio gpiochip0: (1000000.pinctrl): not an immutable
chip, please consider fixing it!
[ 4.741930] gpio gpiochip2: (200f000.spmi:pmic@0:gpios@c000): not
an immutable chip, please consider fixing it!
Links,
- https://lkft.validation.linaro.org/scheduler/job/7060124#L2577
## Build
* kernel: 5.10.202-rc3
* git: https://gitlab.com/Linaro/lkft/mirrors/stable/linux-stable-rc
* git branch: linux-5.10.y
* git commit: 80dc4301c91e15c9c3cf12b393d70e0952bcd9ee
* git describe: v5.10.201-188-g80dc4301c91e
* test details:
https://qa-reports.linaro.org/lkft/linux-stable-rc-linux-5.10.y/build/v5.10.201-188-g80dc4301c91e
## Test Regressions (compared to v5.10.201)
## Metric Regressions (compared to v5.10.201)
## Test Fixes (compared to v5.10.201)
## Metric Fixes (compared to v5.10.201)
## Test result summary
total: 88957, pass: 67831, fail: 3474, skip: 17604, xfail: 48
## Build Summary
* arc: 5 total, 5 passed, 0 failed
* arm: 117 total, 117 passed, 0 failed
* arm64: 44 total, 44 passed, 0 failed
* i386: 35 total, 35 passed, 0 failed
* mips: 24 total, 24 passed, 0 failed
* parisc: 3 total, 0 passed, 3 failed
* powerpc: 25 total, 25 passed, 0 failed
* riscv: 11 total, 11 passed, 0 failed
* s390: 12 total, 12 passed, 0 failed
* sh: 10 total, 10 passed, 0 failed
* sparc: 8 total, 8 passed, 0 failed
* x86_64: 38 total, 38 passed, 0 failed
## Test suites summary
* boot
* kselftest-android
* kselftest-arm64
* kselftest-breakpoints
* kselftest-capabilities
* kselftest-cgroup
* kselftest-clone3
* kselftest-core
* kselftest-cpu-hotplug
* kselftest-cpufreq
* kselftest-drivers-dma-buf
* kselftest-efivarfs
* kselftest-exec
* kselftest-filesystems
* kselftest-filesystems-binderfs
* kselftest-filesystems-epoll
* kselftest-firmware
* kselftest-fpu
* kselftest-ftrace
* kselftest-futex
* kselftest-gpio
* kselftest-intel_pstate
* kselftest-ipc
* kselftest-ir
* kselftest-kcmp
* kselftest-kexec
* kselftest-kvm
* kselftest-lib
* kselftest-membarrier
* kselftest-memfd
* kselftest-memory-hotplug
* kselftest-mincore
* kselftest-mount
* kselftest-mqueue
* kselftest-net
* kselftest-net-forwarding
* kselftest-net-mptcp
* kselftest-netfilter
* kselftest-nsfs
* kselftest-openat2
* kselftest-pid_namespace
* kselftest-pidfd
* kselftest-proc
* kselftest-pstore
* kselftest-ptrace
* kselftest-rseq
* kselftest-rtc
* kselftest-sigaltstack
* kselftest-size
* kselftest-tc-testing
* kselftest-timens
* kselftest-tmpfs
* kselftest-tpm2
* kselftest-user
* kselftest-user_events
* kselftest-vDSO
* kselftest-vm
* kselftest-x86
* kselftest-zram
* kunit
* libgpiod
* log-parser-boot
* log-parser-test
* ltp-cap_bounds
* ltp-commands
* ltp-containers
* ltp-controllers
* ltp-cpuhotplug
* ltp-crypto
* ltp-cve
* ltp-dio
* ltp-fcntl-locktests
* ltp-filecaps
* ltp-fs
* ltp-fs_bind
* ltp-fs_perms_simple
* ltp-fsx
* ltp-hugetlb
* ltp-io
* ltp-ipc
* ltp-math
* ltp-mm
* ltp-nptl
* ltp-pty
* ltp-sched
* ltp-securebits
* ltp-smoke
* ltp-syscalls
* ltp-tracing
* perf
* rcutorture
--
Linaro LKFT
https://lkft.linaro.org
^ permalink raw reply [flat|nested] 18+ messages in thread