From: Lee Jones <lee@kernel.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: Andrew Lunn <andrew@lunn.ch>, Pavel Machek <pavel@ucw.cz>,
Christian Marangi <ansuelsmth@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Li Zetao <lizetao1@huawei.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: trigger: netdev: extend speeds up to 10G
Date: Mon, 27 Nov 2023 08:13:05 +0000 [thread overview]
Message-ID: <20231127081305.GB1470173@google.com> (raw)
In-Reply-To: <ZWPCdHBt_g4-5ArV@makrotopia.org>
On Sun, 26 Nov 2023, Daniel Golle wrote:
> Hi Andrew,
>
> On Sun, Nov 26, 2023 at 10:04:22PM +0100, Andrew Lunn wrote:
> > On Sun, Nov 26, 2023 at 08:17:03PM +0000, Daniel Golle wrote:
> > > Add 2.5G, 5G and 10G as available speeds to the netdev LED trigger.
> > >
> > > Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> >
> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> >
> > One thing to consider is how this get merged. I assume you will have a
> > PHY driver patch soon making use of this?
>
> Yes, exactly. I'm working on adding support for LEDs to MaxLinear and
> RealTek PHY drivers.
>
> > We can either:
> >
> > 1) Get Lee to merge it into the LED tree and then create a stable
> > branch which gets pulled into netdev.
I'll create an immutable branch.
> > 2) Merge into netdev, with Lees Acked-by:
> >
> > It seems unlikely there will be any merge conflicts. So netdev does
> > seem like an O.K. way to go.
>
> Via netdev (net-next) would be better imho as it would allow to add
> changes to PHY drivers making use of the new constants without having
> to wait for LED tree being merged.
The former solution does not prevent this.
> Note that I've sent v2 which adds missing use of sysfs attributes.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2023-11-27 8:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-26 20:17 [PATCH] leds: trigger: netdev: extend speeds up to 10G Daniel Golle
2023-11-26 21:04 ` Andrew Lunn
2023-11-26 22:11 ` Daniel Golle
2023-11-27 8:13 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231127081305.GB1470173@google.com \
--to=lee@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox