From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Yaxiong Tian <iambestgod@outlook.com>
Cc: michael.jamet@intel.com, gregkh@linuxfoundation.org,
andreas.noever@gmail.com, YehezkelShB@gmail.com,
tianyaxiong@kylinos.cn, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thunderbolt:debugfs:Fix memory leak with using debugfs_lookup()
Date: Mon, 27 Nov 2023 12:59:14 +0200 [thread overview]
Message-ID: <20231127105914.GL1074920@black.fi.intel.com> (raw)
In-Reply-To: <TYZPR01MB478461E6616835634D0718F8D5BAA@TYZPR01MB4784.apcprd01.prod.exchangelabs.com>
On Wed, Nov 22, 2023 at 04:02:43PM +0800, Yaxiong Tian wrote:
> From: Yaxiong Tian <tianyaxiong@kylinos.cn>
>
> As Greg said,When calling debugfs_lookup() the result must have dput()
> called on it,otherwise the memory will leak over time.
> So just call debugfs_lookup_and_remove() instead.
>
> Fixes: d0f1e0c2a699 ("thunderbolt: Add support for receiver lane margining")
> Signed-off-by: Yaxiong Tian <tianyaxiong@kylinos.cn>
Slightly modified the commit log and applied to thunderbolt.git/fixes, thanks!
prev parent reply other threads:[~2023-11-27 10:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 8:02 [PATCH] thunderbolt:debugfs:Fix memory leak with using debugfs_lookup() Yaxiong Tian
2023-11-27 10:59 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231127105914.GL1074920@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=iambestgod@outlook.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=tianyaxiong@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox