From: Jason Gunthorpe <jgg@nvidia.com>
To: "Zhang, Tina" <tina.zhang@intel.com>
Cc: Joerg Roedel <joro@8bytes.org>,
"iommu@lists.linux.dev" <iommu@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
David Woodhouse <dwmw2@infradead.org>,
Lu Baolu <baolu.lu@linux.intel.com>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
Nicolin Chen <nicolinc@nvidia.com>,
Michael Shavit <mshavit@google.com>,
Vasant Hegde <vasant.hegde@amd.com>
Subject: Re: [PATCH v10 1/6] iommu: Change kconfig around IOMMU_SVA
Date: Mon, 27 Nov 2023 14:24:41 -0400 [thread overview]
Message-ID: <20231127182441.GA1170207@nvidia.com> (raw)
In-Reply-To: <20231027112013.GT3952@nvidia.com>
On Fri, Oct 27, 2023 at 08:20:13AM -0300, Jason Gunthorpe wrote:
> On Fri, Oct 27, 2023 at 09:14:17AM +0000, Zhang, Tina wrote:
> > > > On Fri, Oct 27, 2023 at 08:05:20AM +0800, Tina Zhang wrote:
> > > > > From: Jason Gunthorpe <jgg@nvidia.com>
> > > > >
> > > > > Linus suggested that the kconfig here is confusing:
> > > >
> > > > While this patch looks decent to me, you forgot to Cc Linus on it. In
> > > > general, given that it touches a couple of core files, I'd like to
> > > > wait for some more people to have a look at it and not rushing anything in.
> > > Make sense. I'll CC Linus. Comments are welcome.
>
> > Can we separate this patch? I'm thinking about CC more people for
> > review. At least, we need to CC all the reviewers of
> > https://lore.kernel.org/all/20230506133134.1492395-1-jacob.jun.pan@linux.intel.com/
> > to this patch. So, it seems more reasonable to separate this
> > patch. What do you think?
>
> I think that makes sense, let's go ahead with the rest of the SVA
> series and we can do this next cycle. Bikeshedding config names isn't
> really critical.
So this didn't make it even without the config change :(
Can you please resend it again and CC the right please please. This
needs to go into this cycle for sure
Thanks
Jason
next prev parent reply other threads:[~2023-11-27 18:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 0:05 [PATCH v10 0/6] Share sva domains with all devices bound to a mm Tina Zhang
2023-10-27 0:05 ` [PATCH v10 1/6] iommu: Change kconfig around IOMMU_SVA Tina Zhang
2023-10-27 7:12 ` Joerg Roedel
2023-10-27 7:36 ` Zhang, Tina
2023-10-27 9:14 ` Zhang, Tina
2023-10-27 11:20 ` Jason Gunthorpe
2023-11-27 18:24 ` Jason Gunthorpe [this message]
2023-11-28 0:23 ` Zhang, Tina
2023-10-27 0:05 ` [PATCH v10 2/6] iommu/vt-d: Remove mm->pasid in intel_sva_bind_mm() Tina Zhang
2023-10-27 0:05 ` [PATCH v10 3/6] iommu: Add mm_get_enqcmd_pasid() helper function Tina Zhang
2023-10-27 0:05 ` [PATCH v10 4/6] mm: Add structure to keep sva information Tina Zhang
2023-10-27 0:05 ` [PATCH v10 5/6] iommu: Support mm PASID 1:n with sva domains Tina Zhang
2024-02-20 16:26 ` Zhangfei Gao
2024-02-20 23:58 ` Zhang, Tina
2024-02-21 1:28 ` Zhangfei Gao
2024-02-21 1:53 ` Zhangfei Gao
2024-02-21 2:06 ` Baolu Lu
2024-02-21 2:45 ` Zhangfei Gao
2024-02-21 3:52 ` Baolu Lu
2024-02-21 6:26 ` Zhangfei Gao
2024-02-21 7:41 ` Zhang, Tina
2024-02-21 8:01 ` Zhangfei Gao
2023-10-27 0:05 ` [PATCH v10 6/6] mm: Deprecate pasid field Tina Zhang
2023-12-12 9:12 ` [PATCH v10 0/6] Share sva domains with all devices bound to a mm Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231127182441.GA1170207@nvidia.com \
--to=jgg@nvidia.com \
--cc=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mshavit@google.com \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=tina.zhang@intel.com \
--cc=vasant.hegde@amd.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox