From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9202C07CB1 for ; Tue, 28 Nov 2023 03:02:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234537AbjK1DCX (ORCPT ); Mon, 27 Nov 2023 22:02:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234547AbjK1DCT (ORCPT ); Mon, 27 Nov 2023 22:02:19 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDC9F10CC for ; Mon, 27 Nov 2023 19:02:23 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 15E42C433CA; Tue, 28 Nov 2023 03:02:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701140543; bh=jjjxMjmEbU3Pkl9GYKm1Qg0uq2791T4WlUMI7FS8u0k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KGS5RBhhvx2O298BY1FJCYbxlmRZfbtr1cJKj1PFJxuKzWSFPlNde1pKOFYQEDFR/ j6umy5bIzl068wZBopv30maHFqAoIM6qRYEl6rksm4adz4/huIMhCtJ/la4a6luiwY rZfoHIxXZTKMoAqLkOoRVNNI1BXDbvuwdfxg9KZlOaFHdOmNpHCcEE2P55jO3XzwkF 0OrwJXvA6GNzPf/KoNjNoKR7JLPbKbjOsUZJbJmeLncR7pFyqvUA9IIWW9t8fHbvlx trKDmy/RR/lHYWSmIgsJdJrYeu+b1+N7qEZI9Za8UF5w08qV69ntDdvJYjOADIzhmC /EcZGRzgi+eNQ== Date: Mon, 27 Nov 2023 19:02:22 -0800 From: Jakub Kicinski To: Subbaraya Sundeep Cc: , , , , , , , Subject: Re: [PATCH net] octeontx2-af: Check return value of nix_get_nixlf before using nixlf Message-ID: <20231127190222.293afaec@kernel.org> In-Reply-To: <1700930098-5483-1-git-send-email-sbhatta@marvell.com> References: <1700930098-5483-1-git-send-email-sbhatta@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 25 Nov 2023 22:04:58 +0530 Subbaraya Sundeep wrote: > If a NIXLF is not attached to a PF/VF device then > nix_get_nixlf function fails and returns proper error > code. But npc_get_default_entry_action does not check it > and uses garbage value in subsequent calls. Fix this > by cheking the return value of nix_get_nixlf. > > Fixes: 967db3529eca ("octeontx2-af: add support for multicast/promisc packet replication feature") You need to run the patch thru scripts/get_maintainer, here you missed CCing Naveen, who authored 967db3529eca. Also lcherian@marvell.com and jerinj@marvell.com LMK if these people are no longer at marvell, I can add their addresses to our ignore list. Same goes for the pauseparam patch, you'll need to repost the two. -- pw-bot: cr