From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B3E6C4167B for ; Mon, 27 Nov 2023 13:54:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233607AbjK0Nyg (ORCPT ); Mon, 27 Nov 2023 08:54:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233349AbjK0NyM (ORCPT ); Mon, 27 Nov 2023 08:54:12 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B680A10C1 for ; Mon, 27 Nov 2023 05:54:18 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1475FC433C9; Mon, 27 Nov 2023 13:54:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1701093258; bh=ogCda4IEnDbNwVjhJVW41RiF6AQ3B1fNwlkaBmmQ3rU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FBcSYuPWTlZjyqzxwZXmZSuDeaMcwQtlYYSAQGq0iLf50ff8CbHDviDKIw2qbzL1d u0J8KcptauMCV9s8Hm3wK8XZxjq5zFe6F2JNLDba14mB8BrlFSGh9sYf2z1qmAw1wD K8ORd9fh5q5COdIT3wKLBA8O2aI/OmtqGPcenvlE= Date: Mon, 27 Nov 2023 13:32:47 +0000 From: Greg Kroah-Hartman To: "Usyskin, Alexander" Cc: "De Marchi, Lucas" , "Ceraolo Spurio, Daniele" , "Vivi, Rodrigo" , "Winkler, Tomas" , "Lubart, Vitaly" , "intel-xe@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 5/5] mei: pxp: add dependency on Xe driver Message-ID: <2023112729-quench-device-397c@gregkh> References: <20231107134606.316651-1-alexander.usyskin@intel.com> <20231107134606.316651-6-alexander.usyskin@intel.com> <2023110700-emptier-retrain-08fd@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 07, 2023 at 02:26:17PM +0000, Usyskin, Alexander wrote: > > > > On Tue, Nov 07, 2023 at 03:46:06PM +0200, Alexander Usyskin wrote: > > > Optionally depend on either i915 or Xe drivers. > > > > > > Signed-off-by: Alexander Usyskin > > > --- > > > drivers/misc/mei/pxp/Kconfig | 3 +-- > > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > > > diff --git a/drivers/misc/mei/pxp/Kconfig b/drivers/misc/mei/pxp/Kconfig > > > index 4029b96afc04..d9ae5483567f 100644 > > > --- a/drivers/misc/mei/pxp/Kconfig > > > +++ b/drivers/misc/mei/pxp/Kconfig > > > @@ -1,11 +1,10 @@ > > > - > > > > Why this change here? > > I've been told that SPDX should be the first line in the file, > but here fist line is an empty line. > I can drop this change if it is inappropriate to put it in this patch. It should not go into this patch. Remember, each patch should only do "one thing". thanks, greg k-h