Re: [PATCH v2 05/13] crypto: simd - Update `walksize` in simd skcipher

Jerry Shih
2023-12-08T04:18:49Z

On Dec 8, 2023, at 12:05, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Mon, Nov 27, 2023 at 03:06:55PM +0800, Jerry Shih wrote:
>> The `walksize` assignment is missed in simd skcipher.
>>
>> Signed-off-by: Jerry Shih <jerry.shih@sifive.com>
>> ---
>> crypto/cryptd.c | 1 +
>> crypto/simd.c | 1 +
>> 2 files changed, 2 insertions(+)
>>
>> diff --git a/crypto/cryptd.c b/crypto/cryptd.c
>> index bbcc368b6a55..253d13504ccb 100644
>> --- a/crypto/cryptd.c
>> +++ b/crypto/cryptd.c
>> @@ -405,6 +405,7 @@ static int cryptd_create_skcipher(struct crypto_template *tmpl,
>> (alg->base.cra_flags & CRYPTO_ALG_INTERNAL);
>> inst->alg.ivsize = crypto_skcipher_alg_ivsize(alg);
>> inst->alg.chunksize = crypto_skcipher_alg_chunksize(alg);
>> + inst->alg.walksize = crypto_skcipher_alg_walksize(alg);
>> inst->alg.min_keysize = crypto_skcipher_alg_min_keysize(alg);
>> inst->alg.max_keysize = crypto_skcipher_alg_max_keysize(alg);
>
> Sorry but this patch doesn't apply any more now that we have
> lskcipher.

The lskcipher is merged in kernel `6.7`. I will rebase the v3 series to `6.7` later.
Link: https://lore.kernel.org/all/20231205092801.1335-1-jerry.shih@sifive.com/

Some dependent patches are not applicable to `6.7` now. I will check the status for the
dependent patches.

-Jerry