Re: [PATCH v2 0/6] PCI: Fix deadlocks when enabling ASPM

Bjorn Helgaas
2023-12-11T18:11:58Z

On Mon, Dec 11, 2023 at 06:35:46PM +0100, Johan Hovold wrote:
> Hi Bjorn,
>
> On Fri, Dec 08, 2023 at 11:53:12AM -0600, Bjorn Helgaas wrote:
> > On Tue, Nov 28, 2023 at 09:15:06AM +0100, Johan Hovold wrote:
>
> > > Johan Hovold (6):
> > > PCI/ASPM: Add locked helper for enabling link state
> > > PCI: vmd: Fix deadlock when enabling ASPM
> > > PCI: qcom: Fix deadlock when enabling ASPM
> > > PCI: qcom: Clean up ASPM comment
> > > PCI/ASPM: Clean up disable link state parameter
> > > PCI/ASPM: Add lockdep assert to link state helper
>
> > Applied to for-linus for v6.7, thanks, Johan!
>
> I've noticed that you're pretty keen on amending commit messages.
>
> For this series, for example, I noticed that you added an American comma
> after "e.g." even though this is not expected in British English that I
> (try to) use. This risks introducing inconsistencies and frankly I see no
> reason for this kind of editing. British English is not an error. :)
>
> You also added a plus sign after the stable kernel versions in the
> comments after the CC-stable tags even though this is not the right
> notation for this (see the stable kernel rules).

Fixed, sorry.