From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Vignesh Raman <vignesh.raman@collabora.com>,
"David E. Box" <david.e.box@linux.intel.com>,
Bjorn Helgaas <helgaas@kernel.org>,
daniels@collabora.com, linux-pci@vger.kernel.org,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, helen.koike@collabora.com
Subject: Re: [PATCH] PCI: qcom: Fix compile error
Date: Tue, 28 Nov 2023 16:15:49 +0530 [thread overview]
Message-ID: <20231128104549.GM3088@thinkpad> (raw)
In-Reply-To: <87a5qy88mx.fsf@intel.com>
On Tue, Nov 28, 2023 at 12:39:02PM +0200, Jani Nikula wrote:
> On Tue, 28 Nov 2023, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> wrote:
> > On Tue, Nov 28, 2023 at 11:44:26AM +0530, Vignesh Raman wrote:
> >> Hi Mani,
> >>
> >> On 28/11/23 10:44, Manivannan Sadhasivam wrote:
> >> > On Tue, Nov 28, 2023 at 09:50:26AM +0530, Vignesh Raman wrote:
> >> > > Commit a2458d8f618a ("PCI/ASPM: pci_enable_link_state: Add argument
> >> > > to acquire bus lock") has added an argument to acquire bus lock
> >> > > in pci_enable_link_state, but qcom_pcie_enable_aspm calls it
> >> > > without this argument, resulting in below build error.
> >> > >
> >> >
> >> > Where do you see this error? That patch is not even merged. Looks like you are
> >> > sending the patch against some downstream tree.
> >>
> >> I got this error with drm-tip - git://anongit.freedesktop.org/drm-tip
> >>
> >> This commit is merged in drm-intel/topic/core-for-CI -
> >> https://cgit.freedesktop.org/drm-intel/log/?h=topic/core-for-CI
> >>
> >
> > Okay. Since this patch is just for CI, please do not CC linux-pci as it causes
> > confusion.
>
> Agreed. More on-topic for linux-pci is what happened with [1].
>
> We've been running CI with that for months now to avoid lockdep splats,
> and it's obviously in everyone's best interest to get a fix upstream.
>
Yes, ofc. Right now we have 2 series/patches to fix the locking issue:
https://lore.kernel.org/all/20230321233849.3408339-1-david.e.box@linux.intel.com/
https://lore.kernel.org/linux-pci/20231128081512.19387-1-johan+linaro@kernel.org/
Bjorn has to choose one among them.
- Mani
> David, Bjorn?
>
>
> BR,
> Jani.
>
>
> [1] https://lore.kernel.org/all/20230321233849.3408339-1-david.e.box@linux.intel.com/
>
>
>
>
> >
> > - Mani
> >
> >> Regards,
> >> Vignesh
>
> --
> Jani Nikula, Intel
--
மணிவண்ணன் சதாசிவம்
prev parent reply other threads:[~2023-11-28 10:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 4:20 [PATCH] PCI: qcom: Fix compile error Vignesh Raman
2023-11-28 5:14 ` Manivannan Sadhasivam
2023-11-28 6:14 ` Vignesh Raman
2023-11-28 6:51 ` Manivannan Sadhasivam
2023-11-28 7:47 ` Vignesh Raman
2023-11-28 10:39 ` Jani Nikula
2023-11-28 10:45 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128104549.GM3088@thinkpad \
--to=manivannan.sadhasivam@linaro.org \
--cc=daniels@collabora.com \
--cc=david.e.box@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=helen.koike@collabora.com \
--cc=helgaas@kernel.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=vignesh.raman@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox