From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35403C4167B for ; Tue, 28 Nov 2023 11:03:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344294AbjK1LDo (ORCPT ); Tue, 28 Nov 2023 06:03:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344193AbjK1LDn (ORCPT ); Tue, 28 Nov 2023 06:03:43 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40B41A3 for ; Tue, 28 Nov 2023 03:03:50 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB088C433C9; Tue, 28 Nov 2023 11:03:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701169429; bh=RuN83uZU0ViigSxLsl1fezUOYA7OPMFJtWAUwKSFmMM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jH8rMrpuKeWkEUFmqohSTh/33Dmmf9PKYbItvO4e87DYJ/MZ7sD/sLQBK0awgxdg9 4BBIOaP5zk1wTZ54/hVu5xswTa7sQGtwmA4ru7dpQwqF1t0FB+XROrZ4xZBpwMpXIk Tc/rsf2tP3Wsaye/sCCFJ+XJk4UBYiKv5l1xFszFGGNdmMu+z1syVm8NH1Dyr1GABs Hko8L74saFFbJHkeJtDWygxL8UQxpUGY8vjpUuVbthG/7DRxcPbo6r99QDzHknyLqa LOPeku8nr1gAOTz2mRhez+5UvfDOZRlU5ZI9F5YujbCDUCNrCDwWOY//llpbzrd7hk UtLfeziz9CXhQ== Date: Tue, 28 Nov 2023 16:33:38 +0530 From: Manivannan Sadhasivam To: Ziqi Chen Cc: quic_asutoshd@quicinc.com, quic_cang@quicinc.com, bvanassche@acm.org, stanley.chu@mediatek.com, adrian.hunter@intel.com, beanhuo@micron.com, avri.altman@wdc.com, junwoo80.lee@samsung.com, martin.petersen@oracle.com, quic_nguyenb@quicinc.com, quic_nitirawa@quicinc.com, linux-scsi@vger.kernel.org, Alim Akhtar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Geert Uytterhoeven , Sudeep Holla , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH v4] dt-bindings: ufs: Add msi-parent for UFS MCQ Message-ID: <20231128110338.GQ3088@thinkpad> References: <1701144469-1018-1-git-send-email-quic_ziqichen@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1701144469-1018-1-git-send-email-quic_ziqichen@quicinc.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 28, 2023 at 12:07:47PM +0800, Ziqi Chen wrote: > The Message Signaled Interrupts (MSI) support has been introduced in > UFSHCI version 4.0 (JESD223E). The MSI is the recommended interrupt > approach for MCQ. If choose to use MSI, In UFS DT, we need to provide > msi-parent property that point to the hardware entity which serves as > the MSI controller for this UFS controller. > > Acked-by: Krzysztof Kozlowski > Acked-by: Conor Dooley > Signed-off-by: Ziqi Chen Reviewed-by: Manivannan Sadhasivam - Mani > --- > V3 -> V4: Corrected version change format. > V2 -> V3: Wrap commit message to meet Linux coding style. > V1 -> V2: Rebased on Linux 6.7-rc1 and updated the commit message to > incorporate the details about when MCQ/MSI got introduced. > --- > Documentation/devicetree/bindings/ufs/ufs-common.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/ufs/ufs-common.yaml b/Documentation/devicetree/bindings/ufs/ufs-common.yaml > index 985ea8f..31fe7f3 100644 > --- a/Documentation/devicetree/bindings/ufs/ufs-common.yaml > +++ b/Documentation/devicetree/bindings/ufs/ufs-common.yaml > @@ -87,6 +87,8 @@ properties: > description: > Specifies max. load that can be drawn from VCCQ2 supply. > > + msi-parent: true > + > dependencies: > freq-table-hz: [ clocks ] > operating-points-v2: [ clocks, clock-names ] > -- > 2.7.4 > -- மணிவண்ணன் சதாசிவம்