Re: [PATCH v1 1/5] mm/rmap: rename hugepage_add* to hugetlb_add*

Muchun Song
2023-11-29T08:43:29Z

> On Nov 28, 2023, at 22:52, David Hildenbrand <david@redhat.com> wrote:
>
> Let's just call it "hugetlb_".
>
> Yes, it's all already inconsistent and confusing because we have a lot
> of "hugepage_" functions for legacy reasons. But "hugetlb" cannot possibly
> be confused with transparent huge pages, and it matches "hugetlb.c" and
> "folio_test_hugetlb()". So let's minimize confusion in rmap code.
>
> Signed-off-by: David Hildenbrand <david@redhat.com>

Reviewed-by: Muchun Song <songmuchun@bytedance.com>

Thanks.