From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37B92C4167B for ; Tue, 28 Nov 2023 15:22:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346762AbjK1PW3 (ORCPT ); Tue, 28 Nov 2023 10:22:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346750AbjK1PW1 (ORCPT ); Tue, 28 Nov 2023 10:22:27 -0500 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08CA910D2 for ; Tue, 28 Nov 2023 07:22:28 -0800 (PST) Received: from mail.maildlp.com (unknown [172.18.186.31]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4SfmQm6lFjz6D8YL; Tue, 28 Nov 2023 23:22:08 +0800 (CST) Received: from lhrpeml500005.china.huawei.com (unknown [7.191.163.240]) by mail.maildlp.com (Postfix) with ESMTPS id F06551408FF; Tue, 28 Nov 2023 23:22:25 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 28 Nov 2023 15:22:25 +0000 Date: Tue, 28 Nov 2023 15:22:24 +0000 From: Jonathan Cameron To: Huisong Li CC: , , , , , , , Subject: Re: [PATCH v1 2/3] soc: hisilicon: kunpeng_hccs: Add failure log for no _CRS method Message-ID: <20231128152224.00002bd8@Huawei.com> In-Reply-To: <20231109054526.27270-3-lihuisong@huawei.com> References: <20231109054526.27270-1-lihuisong@huawei.com> <20231109054526.27270-3-lihuisong@huawei.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500005.china.huawei.com (7.191.163.240) To lhrpeml500005.china.huawei.com (7.191.163.240) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 9 Nov 2023 13:45:25 +0800 Huisong Li wrote: > Driver gets the PCC channel id by using the PCC GAS in _CRS. > But, currently, if the firmware has no _CRS method on platform, there > is not any failure log. So this patch adds the log for this. > > Signed-off-by: Huisong Li Make sense to me. Reviewed-by: Jonathan Cameron