From: Andrew Morton <akpm@linux-foundation.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Damian Muszynski <damian.muszynski@intel.com>,
linux-kernel@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH v1 1/1] units: Add missing header
Date: Tue, 28 Nov 2023 18:09:57 -0800 [thread overview]
Message-ID: <20231128180957.ac5caa884abb2b5f00ca47c4@linux-foundation.org> (raw)
In-Reply-To: <20231128174404.393393-1-andriy.shevchenko@linux.intel.com>
On Tue, 28 Nov 2023 19:44:03 +0200 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> BITS_PER_BYTE is defined in bits.h.
>
> Fixes: e8eed5f7366f ("units: Add BYTES_PER_*BIT")
This is post-6.6, so the fix should go into this -rc whatever happens, but...
It would be rather nice to know the effects of this change please. Did
some build break?
> --- a/include/linux/units.h
> +++ b/include/linux/units.h
> @@ -2,6 +2,7 @@
> #ifndef _LINUX_UNITS_H
> #define _LINUX_UNITS_H
>
> +#include <linux/bits.h>
> #include <linux/math.h>
>
> /* Metric prefixes in accordance with Système international (d'unités) */
> --
> 2.43.0.rc1.1.gbec44491f096
next prev parent reply other threads:[~2023-11-29 2:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 17:44 [PATCH v1 1/1] units: Add missing header Andy Shevchenko
2023-11-28 22:25 ` Randy Dunlap
2023-11-29 2:09 ` Andrew Morton [this message]
2023-11-29 10:19 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231128180957.ac5caa884abb2b5f00ca47c4@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=damian.muszynski@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox