Re: [PATCH v3 20/22] pinctrl: renesas: Convert to use grp member

Geert Uytterhoeven
2023-11-29T11:14:07Z

Hi Andy,

On Tue, Nov 28, 2023 at 9:04 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
> Convert drivers to use grp member embedded in struct group_desc.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

Thanks for your patch!

> --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> @@ -273,7 +273,7 @@ static int rzg2l_pinctrl_set_mux(struct pinctrl_dev *pctldev,
> struct function_desc *func;
> unsigned int i, *psel_val;
> struct group_desc *group;
> - int *pins;
> + const int *pins;

unsigned, as this no longer signed.

>
> func = pinmux_generic_get_function(pctldev, func_selector);
> if (!func)
> @@ -283,9 +283,9 @@ static int rzg2l_pinctrl_set_mux(struct pinctrl_dev *pctldev,
> return -EINVAL;
>
> psel_val = func->data;
> - pins = group->pins;
> + pins = group->grp.pins;

> --- a/drivers/pinctrl/renesas/pinctrl-rzv2m.c
> +++ b/drivers/pinctrl/renesas/pinctrl-rzv2m.c
> @@ -165,7 +165,7 @@ static int rzv2m_pinctrl_set_mux(struct pinctrl_dev *pctldev,
> struct function_desc *func;
> unsigned int i, *psel_val;
> struct group_desc *group;
> - int *pins;
> + const int *pins;

unsigned

>
> func = pinmux_generic_get_function(pctldev, func_selector);
> if (!func)
> @@ -175,9 +175,9 @@ static int rzv2m_pinctrl_set_mux(struct pinctrl_dev *pctldev,
> return -EINVAL;
>
> psel_val = func->data;
> - pins = group->pins;
> + pins = group->grp.pins;

With the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds