Re: [PATCH v3 11/22] pinctrl: ingenic: Make use of PINCTRL_GROUP_DESC()

Paul Cercueil
2023-11-29T12:40:40Z

Le mardi 28 novembre 2023 à 21:57 +0200, Andy Shevchenko a écrit :
> Make use of PINCTRL_GROUP_DESC() instead of open coding it.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

I missed this one in your V2 (didn't notice that there were 2 patches
touching pinctrl-ingenic).

Acked-by: Paul Cercueil <paul@crapouillou.net>

Cheers,
-Paul

> ---
>  drivers/pinctrl/pinctrl-ingenic.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-ingenic.c
> b/drivers/pinctrl/pinctrl-ingenic.c
> index ee718f6e2556..393873de910a 100644
> --- a/drivers/pinctrl/pinctrl-ingenic.c
> +++ b/drivers/pinctrl/pinctrl-ingenic.c
> @@ -83,15 +83,10 @@
>  #define JZ4730_PINS_PER_PAIRED_REG 16
>
>  #define INGENIC_PIN_GROUP_FUNCS(name, id, funcs) \
> - { \
> - name, \
> - id##_pins, \
> - ARRAY_SIZE(id##_pins), \
> - funcs, \
> - }
> + PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins),
> funcs)
>
>  #define INGENIC_PIN_GROUP(name, id, func) \
> - INGENIC_PIN_GROUP_FUNCS(name, id, (void *)(func))
> + PINCTRL_GROUP_DESC(name, id##_pins, ARRAY_SIZE(id##_pins),
> (void *)(func))
>
>  enum jz_version {
>   ID_JZ4730,