From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50C50C4167B for ; Tue, 28 Nov 2023 20:41:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346034AbjK1UlX (ORCPT ); Tue, 28 Nov 2023 15:41:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229543AbjK1UlU (ORCPT ); Tue, 28 Nov 2023 15:41:20 -0500 Received: from mail.andi.de1.cc (mail.andi.de1.cc [IPv6:2a02:c205:3004:2154::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3F0B9170B; Tue, 28 Nov 2023 12:41:25 -0800 (PST) Received: from p200301077700a9001093e13752edbf74.dip0.t-ipconnect.de ([2003:107:7700:a900:1093:e137:52ed:bf74] helo=akair) by mail.andi.de1.cc with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r84tU-006otY-HU; Tue, 28 Nov 2023 21:41:20 +0100 Date: Tue, 28 Nov 2023 21:41:16 +0100 From: Andreas Kemnade To: Krzysztof Kozlowski Cc: mturquette@baylibre.com, sboyd@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, kristo@kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH] dt-bindings: clock: ti: Convert interface.txt to json-schema Message-ID: <20231128214116.22dfff1e@akair> In-Reply-To: <7361082a-f271-4ef4-9dad-06ee7445c749@linaro.org> References: <20231127202359.145778-1-andreas@kemnade.info> <7a62ed8a-b0e3-4881-90d7-b8f5d38e482e@linaro.org> <20231128093241.707a4fa0@aktux> <7361082a-f271-4ef4-9dad-06ee7445c749@linaro.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.37; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Tue, 28 Nov 2023 09:41:23 +0100 schrieb Krzysztof Kozlowski : [...] > > We have two usecases here (status quo in dts usage and code): > > If these interface clocks are below a ti,clksel then we are > > describing multiple bits in the same register and therefore every > > child of ti,clksel would have the same reg. > > Regs can have bits, so that could still work. > Yes, it could. Things could be designed in another way. But for now I want to get rid of dtbs_check warnings and finally have some fun with that and not always tempted to skip it and just copy over $bad_example. So I am not in the mood of redesigning everything. > > If the interface clock is not below a ti,clksel then we have reg. > > This should be expressed in the bindings. It's fine to make the reg > optional (skip the description, it's confusing), but the ti,clksel > should reference this schema and enforce it on the children. > Well there are other compatibles below ti,clksel, too, so should we rather add them when the other .txt files are converted? Regards, Andreas