Re: [PATCH v4 05/45] drm/connector: Check drm_connector_init pointers arguments

Ville Syrjälä
2023-11-29T10:26:53Z

On Wed, Nov 29, 2023 at 12:12:59PM +0200, Pekka Paalanen wrote:
> On Tue, 28 Nov 2023 15:49:08 +0200
> Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
>
> > Should we perhaps start to use the (arguably hideous)
> > - void f(struct foo *bar)
> > + void f(struct foo bar[static 1])
> > syntax to tell the compiler we don't accept NULL pointers?
> >
> > Hmm. Apparently that has the same problem as using any
> > other kind of array syntax in the prototype. That is,
> > the compiler demands to know the definition of 'struct foo'
> > even though we're passing in effectively a pointer. Sigh.
>
>
> __attribute__((nonnull)) ?

I guess that would work, though the syntax is horrible when
you need to flag specific arguments.

--
Ville Syrjälä
Intel