From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Ricky WU <ricky_wu@realtek.com>
Cc: "arnd@arndb.de" <arnd@arndb.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"frank.li@vivo.com" <frank.li@vivo.com>,
"u.kleine-koenig@pengutronix.de" <u.kleine-koenig@pengutronix.de>,
"yangyingliang@huawei.com" <yangyingliang@huawei.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH v5 0/3] Support new card reader rts5264
Date: Tue, 28 Nov 2023 07:40:21 +0000 [thread overview]
Message-ID: <2023112848-handoff-wistful-dec5@gregkh> (raw)
In-Reply-To: <d166d6a70c46419f8d2670e63f542ea1@realtek.com>
On Tue, Nov 28, 2023 at 05:32:47AM +0000, Ricky WU wrote:
> Summary
> =======
> This series adds support new card reader rts5264
> rts5264 can support sd express card
> new definitions and functions define in new file rts5264.h rts5264.c
>
> Patch structure
> ===============
> v4->v5:
> add summary for this series
That is not what I asked for here. Please make the changelog text for
the individual patches MUCH better. Perhaps work with one of your
coworkers to come up with some more text that properly describes what
the change is doing? Did you read the documentation link that I pointed
you at that should answer how to do this better?
Also, your patches are NOT properly linked together (look at them on
lore.kernel.org for proof), please use something like git send-email to
have them be linked so that we can apply them properly at the same time
together once they are ready.
thanks,
greg k-h
prev parent reply other threads:[~2023-11-28 7:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 5:32 [PATCH v5 0/3] Support new card reader rts5264 Ricky WU
2023-11-28 7:40 ` gregkh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023112848-handoff-wistful-dec5@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=frank.li@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ricky_wu@realtek.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=ulf.hansson@linaro.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox