From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A451FC4167B for ; Tue, 28 Nov 2023 07:40:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343840AbjK1HkX (ORCPT ); Tue, 28 Nov 2023 02:40:23 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343828AbjK1HkT (ORCPT ); Tue, 28 Nov 2023 02:40:19 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE965D4D for ; Mon, 27 Nov 2023 23:40:25 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 06171C433C8; Tue, 28 Nov 2023 07:40:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1701157225; bh=sQ8eFRy8ecWkoljPx54B1yii7txseyEFBs2HyY8n+wk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0CknmWSAvMLQx5OiL5X7KW4Iw2Mrbo6oKxUPdjCYpr07sE0c/WFbDsrkiNm1pS4g7 XdHyAQUn9+EDO59QVR6mA2OIJabxl1GhzzO0w44IMVaEAjwOyn4iMloe/g/P80fLVW l1/Kojo5fk1mip0XLmakL/SIJxPquRGz46TiouYo= Date: Tue, 28 Nov 2023 07:40:21 +0000 From: "gregkh@linuxfoundation.org" To: Ricky WU Cc: "arnd@arndb.de" , "linux-kernel@vger.kernel.org" , "ulf.hansson@linaro.org" , "frank.li@vivo.com" , "u.kleine-koenig@pengutronix.de" , "yangyingliang@huawei.com" , "linux-mmc@vger.kernel.org" Subject: Re: [PATCH v5 0/3] Support new card reader rts5264 Message-ID: <2023112848-handoff-wistful-dec5@gregkh> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 28, 2023 at 05:32:47AM +0000, Ricky WU wrote: > Summary > ======= > This series adds support new card reader rts5264 > rts5264 can support sd express card > new definitions and functions define in new file rts5264.h rts5264.c > > Patch structure > =============== > v4->v5: > add summary for this series That is not what I asked for here. Please make the changelog text for the individual patches MUCH better. Perhaps work with one of your coworkers to come up with some more text that properly describes what the change is doing? Did you read the documentation link that I pointed you at that should answer how to do this better? Also, your patches are NOT properly linked together (look at them on lore.kernel.org for proof), please use something like git send-email to have them be linked so that we can apply them properly at the same time together once they are ready. thanks, greg k-h