From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50CC7C4167B for ; Wed, 29 Nov 2023 10:53:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230305AbjK2KxB (ORCPT ); Wed, 29 Nov 2023 05:53:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229477AbjK2Kw7 (ORCPT ); Wed, 29 Nov 2023 05:52:59 -0500 Received: from desiato.infradead.org (desiato.infradead.org [IPv6:2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA82010CE; Wed, 29 Nov 2023 02:53:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=/OekEShUlQdJpo7AqAfaxY+vi6Bol0LFK9LTWBoiQ5M=; b=abH9ikdMp2xRajwn9eXjNI/KOg Lugjk+J03nV25J4wm8/VAsB0k9Bq9Fyvu9PUe/dU8oZDnvjoXoUwWhpvB13zqiK76ie8AqQKiaVIL QrnjLjqnMAWY3FzNnL64l9KwFK6OWKI+vhrQc6er/btaes0Iu1me2jWgNdBFBZRXvNKcv1K2FKHvp glxDq3LMgoZ4nyGu2fzvAm0rLTQO8QhMEKSXlXuYCLZvW5Oz0krdizLlmseM+UDtl4xK3+b5WVqbO S4u1awcHr6Xr6jeE9arGWFB1upo8yi8jXcEzY73+RqUSM9D3ueK6t/xnbtusOC+ScXoLotNS3cq7r hDCZWf8A==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1r8IAh-000Jk4-0K; Wed, 29 Nov 2023 10:52:01 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 01183300293; Wed, 29 Nov 2023 11:51:57 +0100 (CET) Date: Wed, 29 Nov 2023 11:51:57 +0100 From: Peter Zijlstra To: Adrian Hunter Cc: Ingo Molnar , Mark Rutland , Alexander Shishkin , Heiko Carstens , Thomas Richter , Hendrik Brueckner , Suzuki K Poulose , Mike Leach , James Clark , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, Yicong Yang , Jonathan Cameron , Will Deacon , Arnaldo Carvalho de Melo , Jiri Olsa , Namhyung Kim , Ian Rogers , linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Subject: Re: [PATCH RFC 1/3] perf/core: Add aux_pause, aux_resume, aux_start_paused Message-ID: <20231129105157.GE30650@noisy.programming.kicks-ass.net> References: <20231123121851.10826-1-adrian.hunter@intel.com> <20231123121851.10826-2-adrian.hunter@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231123121851.10826-2-adrian.hunter@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 23, 2023 at 02:18:49PM +0200, Adrian Hunter wrote: > diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h > index 39c6a250dd1b..1232e70adfba 100644 > --- a/include/uapi/linux/perf_event.h > +++ b/include/uapi/linux/perf_event.h > @@ -456,7 +456,8 @@ struct perf_event_attr { > inherit_thread : 1, /* children only inherit if cloned with CLONE_THREAD */ > remove_on_exec : 1, /* event is removed from task on exec */ > sigtrap : 1, /* send synchronous SIGTRAP on event */ > - __reserved_1 : 26; > + aux_start_paused : 1, /* start AUX area tracing paused */ > + __reserved_1 : 25; > > union { > __u32 wakeup_events; /* wakeup every n events */ > @@ -507,7 +508,15 @@ struct perf_event_attr { > __u16 sample_max_stack; > __u16 __reserved_2; > __u32 aux_sample_size; > - __u32 __reserved_3; > + > + union { > + __u32 aux_output_cfg; > + struct { > + __u64 aux_pause : 1, /* on overflow, pause AUX area tracing */ > + aux_resume : 1, /* on overflow, resume AUX area tracing */ > + __reserved_3 : 30; > + }; > + }; > > /* > * User provided data if sigtrap=1, passed back to user via So since you're adding a aux_output_cfg word, could you not also put the start_paused thing in there?