Re: [PATCH v6 3/6] net: phy: at803x: add QCA8084 ethernet phy support

Russell King (Oracle)
2023-11-28T09:00:56Z

On Tue, Nov 28, 2023 at 03:16:45PM +0800, Jie Luo wrote:
> > > The interface mode is passed in the .config_init, which is configured
> > > by the PCS driver, the hardware register is located in the PCS, this
> > > driver will be pushed later.
> >
> > Is this the same as how the syqca807x works? Can the PCS driver be
> > shared by these two drivers?
>
> I am not sure syqca807x, would you point me the code path of this driver?
>
> >
> > What i don't like at the moment is that we have two driver
> > developments going on at once for hardware which seems very similar,
> > but no apparent cooperation?
> >
> > Andrew
>
> The PCS of qca8084 is the PHY PCS, which should be new PCS driver,
> in the previous chips, we don't have this kind of PHY PCS.

No. PCS drivers are for MAC-side PCS drivers, not PHY-side PCS drivers.

+-------------
| PHY
MAC---PCS --- link --- PCS --- ...
^ | ^
| +--|----------
For this PCS |
Not for this PCS

--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!