From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9B2EC4167B for ; Wed, 29 Nov 2023 23:06:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343556AbjK2XG1 (ORCPT ); Wed, 29 Nov 2023 18:06:27 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229575AbjK2XGZ (ORCPT ); Wed, 29 Nov 2023 18:06:25 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46142D5E for ; Wed, 29 Nov 2023 15:06:31 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 934F7C433C8; Wed, 29 Nov 2023 23:06:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1701299190; bh=/WgUayWWWkxbFck8hTcs1QOiZXOjLOOEvYOvKvwD0iE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PN4mgVDNZWOM3Mt13aA18yzTp+QM/mNKDN/09Nhq5W+eUSveBnuef43Nqosb9pBkG 9iAMbd20kI1HdnnWI3rgqxfSOJaquDyQSR2L3HkGlSwHGbLSDuNwLNg9QpRVBQ/1Lk CC/lJITRwxVcvgIrsNaknnVa+vZd/er4eL4fgkvI= Date: Wed, 29 Nov 2023 15:06:29 -0800 From: Andrew Morton To: Florian Fainelli Cc: "linux-kernel@vger.kernel.org" , Jan Kiszka , Kieran Bingham , Shanker Donthineni , Kuan-Ying Lee , AngeloGioacchino Del Regno Subject: Re: No care given to GDB scripts.. Message-Id: <20231129150629.0a82efbfc1494972e4e4f8cb@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 29 Nov 2023 14:48:02 -0800 Florian Fainelli wrote: > Hello, > > It is quite clear that there are zero cares being given to making sure > that GDB scripts continue to work after making changes to core kernel > code, and why would you, because you probably did not know those > existed, but they do and they are used, and useful. > > A recent example that was fixed by Kuan-Ying is this: > > and now of course, "lx-interupts" also stopped working altogether after > this change: > > https://lore.kernel.org/r/20230519134902.1495562-4-sdonthineni@nvidia.com > > and who knows what else I could not test that is also broken. > > We really need to find a better way to stop breaking GDB scripts, they > break way too often to be even remotely usable, and this is really sad. > > It is also quite clear that we do not have enough continuous integration > and regression testing to ensure those breakages are caught ahead of time... > This isn't terribly surprising - the gdb scripts are a pretty remote corner and are peculiarly sensitive to getting damaged by routine kernel development. Is there any way of scripting the scripts so we can have some sort of automated testing down under tools/testing/selftests/?