From: Oleg Nesterov <oleg@redhat.com>
To: David Howells <dhowells@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Marc Dionne <marc.dionne@auristor.com>,
linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] afs: fix the usage of read_seqbegin_or_lock()
Date: Thu, 30 Nov 2023 12:55:37 +0100 [thread overview]
Message-ID: <20231130115537.GA21550@redhat.com> (raw)
Hello,
Every usage of read_seqbegin_or_lock() in fs/afs is wrong, the counter is
always even so read_seqbegin_or_lock() can never take the lock.
The users should either make it odd on the 2nd pass, or use read_seqbegin()
instead.
Oleg.
---
fs/afs/callback.c | 3 ++-
fs/afs/inode.c | 15 ++++++---------
fs/afs/server.c | 7 ++++---
3 files changed, 12 insertions(+), 13 deletions(-)
next reply other threads:[~2023-11-30 11:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 11:55 Oleg Nesterov [this message]
2023-11-30 11:56 ` [PATCH 1/3] afs: fix the usage of read_seqbegin_or_lock() in afs_lookup_volume_rcu() Oleg Nesterov
2023-11-30 11:56 ` [PATCH 2/3] afs: fix the usage of read_seqbegin_or_lock() in afs_find_server*() Oleg Nesterov
2023-11-30 11:56 ` [PATCH 3/3] afs: use read_seqbegin() in afs_check_validity() and afs_getattr() Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231130115537.GA21550@redhat.com \
--to=oleg@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox