public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: X86 ML <x86@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [RFC PATCH] x86/Kconfig: Disable KASLR on debug builds
Date: Thu, 30 Nov 2023 13:05:52 +0100	[thread overview]
Message-ID: <20231130120552.6735-1-bp@alien8.de> (raw)

From: "Borislav Petkov (AMD)" <bp@alien8.de>

Having KASLR enabled makes debugging a kernel completely useless because
virtual addresses are not stable, leading to people poking at kernel
internals to have to go and rebuild with RANDOMIZE_BASE=off.

Just disable it on debugging builds where it is not needed anyway.

Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
---
 arch/x86/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index c456c9b1fc7c..da94354b1b75 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -2159,7 +2159,7 @@ config RELOCATABLE
 
 config RANDOMIZE_BASE
 	bool "Randomize the address of the kernel image (KASLR)"
-	depends on RELOCATABLE
+	depends on RELOCATABLE && !DEBUG_KERNEL
 	default y
 	help
 	  In support of Kernel Address Space Layout Randomization (KASLR),
-- 
2.42.0.rc0.25.ga82fb66fed25


             reply	other threads:[~2023-11-30 12:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-30 12:05 Borislav Petkov [this message]
2023-11-30 12:08 ` [RFC PATCH] x86/Kconfig: Disable KASLR on debug builds Peter Zijlstra
2023-11-30 12:49   ` Borislav Petkov
2023-12-04 10:42     ` Mark Rutland
2023-12-04 15:49       ` Borislav Petkov
2023-12-04 17:20         ` Mark Rutland
2023-11-30 18:10 ` Nathan Chancellor
2023-11-30 19:34   ` Borislav Petkov
2023-12-01 16:16     ` Nathan Chancellor
2023-12-01 16:24       ` Borislav Petkov
2023-12-01 16:58         ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231130120552.6735-1-bp@alien8.de \
    --to=bp@alien8.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox