From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id CECDFC4167B
	for <linux-kernel@archiver.kernel.org>; Thu, 30 Nov 2023 17:44:19 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1346620AbjK3RoL (ORCPT
        <rfc822;linux-kernel@archiver.kernel.org>);
        Thu, 30 Nov 2023 12:44:11 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39724 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S231486AbjK3RoI (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 30 Nov 2023 12:44:08 -0500
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B53410E6
        for <linux-kernel@vger.kernel.org>; Thu, 30 Nov 2023 09:44:15 -0800 (PST)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89A85C433C9;
        Thu, 30 Nov 2023 17:44:12 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1701366255;
        bh=uzTkHarOhWkDRPyS2TS5VgefjyqziPWu4KYGuOmUCMY=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=OTsVvuxqonWfqBPO3LoEoMMLCu6SuUZ07G3eOHFqcWj3z9ozDz/7GMiQBpASmAJIC
         9m+cZ8/+8di3YeHnM7QoI9MfKzrJWZQEGCTrPvhTdbjh9wyWejnjZEcIz8+Wnk+sAF
         ic2/WU+BROUoRffGvaaOGUSyGpDEEZBEmJOE8nxCsEkUSS1sv4r599lUvRXiw2/KVz
         h4kUDSsiH2NgvfYfHpWErG4UN++6dJMUilSav2USnSh2QYlZSyi/YHDsnMXdHhR5gG
         +RZA6Aq2ExhTYr2wwsZzLCDAuKrGst83xA+j5ILt8gGpTHXfk9IimKN0Vyq3Xodwsc
         IcGTJaldjbQkQ==
Date:   Thu, 30 Nov 2023 17:44:10 +0000
From:   Simon Horman <horms@kernel.org>
To:     Dinghao Liu <dinghao.liu@zju.edu.cn>
Cc:     Saeed Mahameed <saeedm@nvidia.com>,
        Leon Romanovsky <leon@kernel.org>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Rahul Rameshbabu <rrameshbabu@nvidia.com>,
        Zhengchao Shao <shaozhengchao@huawei.com>,
        Aya Levin <ayal@nvidia.com>, Tariq Toukan <tariqt@nvidia.com>,
        netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] net/mlx5e: fix a potential double-free in
 fs_any_create_groups
Message-ID: <20231130174410.GJ32077@kernel.org>
References: <20231128092904.2916-1-dinghao.liu@zju.edu.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231128092904.2916-1-dinghao.liu@zju.edu.cn>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Nov 28, 2023 at 05:29:01PM +0800, Dinghao Liu wrote:
> When kcalloc() for ft->g succeeds but kvzalloc() for in fails,
> fs_any_create_groups() will free ft->g. However, its caller
> fs_any_create_table() will free ft->g again through calling
> mlx5e_destroy_flow_table(), which will lead to a double-free.
> Fix this by setting ft->g to NULL in fs_any_create_groups().
> 
> Fixes: 0f575c20bf06 ("net/mlx5e: Introduce Flow Steering ANY API")
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> ---
> 
> Changelog:
> 
> v2: Setting ft->g to NULL instead of removing the kfree().

Reviewed-by: Simon Horman <horms@kernel.org>