From: Kees Cook <keescook@chromium.org>
To: Anders Larsen <al@alarsen.net>
Cc: Kees Cook <keescook@chromium.org>,
Ronald Monthero <debug.penguin32@gmail.com>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: [PATCH v2 0/2] qnx4: Avoid confusing compiler about buffer lengths
Date: Thu, 30 Nov 2023 12:51:17 -0800 [thread overview]
Message-ID: <20231130205010.it.412-kees@kernel.org> (raw)
Hi,
This attempts to fix the issue Ronald Monthero found[1]. Avoids using a
too-short struct buffer when reading the string, by using the existing
struct union.
-Kees
[1] https://lore.kernel.org/lkml/20231112095353.579855-1-debug.penguin32@gmail.com/
v2:
- Use BUILD_BUG_ON() instead of _Static_assert()
v1: https://lore.kernel.org/all/20231118032638.work.955-kees@kernel.org/
Kees Cook (2):
qnx4: Extract dir entry filename processing into helper
qnx4: Use get_directory_fname() in qnx4_match()
fs/qnx4/dir.c | 52 ++++++------------------------------------
fs/qnx4/namei.c | 29 +++++++++---------------
fs/qnx4/qnx4.h | 60 +++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 78 insertions(+), 63 deletions(-)
--
2.34.1
next reply other threads:[~2023-11-30 20:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-30 20:51 Kees Cook [this message]
2023-11-30 20:51 ` [PATCH v2 1/2] qnx4: Extract dir entry filename processing into helper Kees Cook
2023-11-30 20:51 ` [PATCH v2 2/2] qnx4: Use get_directory_fname() in qnx4_match() Kees Cook
2023-12-04 15:46 ` [PATCH v2 0/2] qnx4: Avoid confusing compiler about buffer lengths Ronald Monthero
2023-12-04 22:10 ` Kees Cook
2023-12-15 9:29 ` Ronald Monthero
2023-12-12 21:19 ` Kees Cook
2023-12-13 16:43 ` Anders Larsen
2023-12-13 19:18 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231130205010.it.412-kees@kernel.org \
--to=keescook@chromium.org \
--cc=al@alarsen.net \
--cc=debug.penguin32@gmail.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox