Re: [PATCH 2/4] dt-bindings: mfd: hisilicon,hi6421-spmi-pmic: fix example regulator node

Johan Hovold
2023-12-01T16:48:09Z

On Fri, Dec 01, 2023 at 03:42:38PM +0100, Krzysztof Kozlowski wrote:
> On 01/12/2023 15:40, Rob Herring wrote:
> > On Thu, Nov 30, 2023 at 06:25:45PM +0100, Johan Hovold wrote:
> >> The example regulator child nodes do not have unit addresses so drop the
> >> incorrect '#address-cells' and '#size-cells' properties from the parent
> >> node.

> >> regulators {
> >> - #address-cells = <1>;
> >> - #size-cells = <0>;
> >> -
> >
> > It's the right fix, but I have to wonder why these are not schema
> > errors? Seems like something in the schemas needs fixing.
>
> Good point. The fix is just not sufficient. This binding explicitly
> allow it, so it should be removed there as well.

Ah, I missed that. Now fixed up in v2.

Johan