From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14B23C4167B for ; Sun, 3 Dec 2023 17:59:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233819AbjLCR7D (ORCPT ); Sun, 3 Dec 2023 12:59:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229572AbjLCR7B (ORCPT ); Sun, 3 Dec 2023 12:59:01 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67CDFE3 for ; Sun, 3 Dec 2023 09:59:08 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9FEB7C433C8; Sun, 3 Dec 2023 17:59:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1701626348; bh=J3twRl4XxNuaVvsz4IZOORnl97JE03DVpSOJqQMMnrg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XQgnr1CrIXhnmdf9B1ROCZ9SjUSLl9+DBa2byKGWxWoerXSH4yridtiCYIyr0fPfx LDdI/KOIEQIoNN+b45DUi+HZ9CQzBhIqGKwzSZi5gaIsadPkU+ooBj6MD79pJbuZYB a06YP76fOKoZU4QpSPQAkucgBZJ4vpgGlKkBDcxE= Date: Sun, 3 Dec 2023 18:59:04 +0100 From: Greg Kroah-Hartman To: Vladimir Oltean Cc: Bjorn Helgaas , linux-pci@vger.kernel.org, Bjorn Helgaas , linux-kernel@vger.kernel.org, Wasim Khan , Wei Fang , Clark Wang Subject: Re: [PATCH pci] PCI: remove the PCI_VENDOR_ID_NXP alias Message-ID: <2023120318-creme-cold-206b@gregkh> References: <20231122154241.1371647-1-vladimir.oltean@nxp.com> <20231129233827.GA444332@bhelgaas> <2023113014-preflight-roundish-d796@gregkh> <20231203151654.nh4ta7vtzwpwg4ss@skbuf> <2023120354-expansion-frequency-f991@gregkh> <20231203174841.uj6ixj7ap2hzlvey@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231203174841.uj6ixj7ap2hzlvey@skbuf> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 03, 2023 at 07:48:41PM +0200, Vladimir Oltean wrote: > On Sun, Dec 03, 2023 at 06:30:13PM +0100, Greg Kroah-Hartman wrote: > > On Sun, Dec 03, 2023 at 05:16:54PM +0200, Vladimir Oltean wrote: > > > On Thu, Nov 30, 2023 at 11:10:19AM +0000, Greg Kroah-Hartman wrote: > > > > > Why would we remove name of the current company and use the name of a > > > > > company that doesn't exist any more? > > > > > > > > Yes, this seems very odd. What is the reason for any of this other than > > > > marketing? Kernel code doesn't do marketing :) > > > > > > I'm not sure who is doing the marketing; not me, that's for sure. > > > The patch that I'm proposing undoes these strange aliases. > > > > Why? > > Why am I undoing the aliases? It's in my commit message. Which is long gone from this email thread, sorry. > NXP now > produces PCI devices with a different vendor ID. "Different" from what, the old one? > If aliasing is the way > to go, then are we supposed to add a new PCI_VENDOR_ID_NXP2, > PCI_VENDOR_ID_NXP3 etc? > > Mellanox was bought by Nvidia and I don't see its PCI ID aliased to > Nvidia. There are probably countless of other examples. I'm not asking why anything is being aliased, I'm asking why change the existing names. > > Who did it originally in what commit id and what was wrong with them > > then? > > Does it really matter? "Git blame" on the line with #define PCI_VENDOR_ID_NXP > will point to a random commit by Wasim Khan (also CCed). The usage of > PCI_VENDOR_ID_NXP is not widespread, it's only that commit. So does your change here just revert the change in that commit, or does it do it in other places? thanks, greg k-h