* [PATCH] drm/bridge: tc358768: select CONFIG_VIDEOMODE_HELPERS
@ 2023-12-04 7:27 Arnd Bergmann
2023-12-04 9:55 ` Neil Armstrong
2023-12-05 8:33 ` Neil Armstrong
0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2023-12-04 7:27 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Peter Ujfalusi,
Tomi Valkeinen
Cc: Arnd Bergmann, Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Daniel Vetter, dri-devel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
A dependency on this feature was recently introduced:
x86_64-linux-ld: vmlinux.o: in function `tc358768_bridge_pre_enable':
tc358768.c:(.text+0xbe3dae): undefined reference to `drm_display_mode_to_videomode'
Make sure this is always enabled.
Fixes: e5fb21678136 ("drm/bridge: tc358768: Use struct videomode")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/bridge/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
index ba82a1142adf..3e6a4e2044c0 100644
--- a/drivers/gpu/drm/bridge/Kconfig
+++ b/drivers/gpu/drm/bridge/Kconfig
@@ -313,6 +313,7 @@ config DRM_TOSHIBA_TC358768
select REGMAP_I2C
select DRM_PANEL
select DRM_MIPI_DSI
+ select VIDEOMODE_HELPERS
help
Toshiba TC358768AXBG/TC358778XBG DSI bridge chip driver.
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/bridge: tc358768: select CONFIG_VIDEOMODE_HELPERS
2023-12-04 7:27 [PATCH] drm/bridge: tc358768: select CONFIG_VIDEOMODE_HELPERS Arnd Bergmann
@ 2023-12-04 9:55 ` Neil Armstrong
2023-12-05 8:33 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2023-12-04 9:55 UTC (permalink / raw)
To: Arnd Bergmann, Andrzej Hajda, Robert Foss, Peter Ujfalusi,
Tomi Valkeinen
Cc: Arnd Bergmann, Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Daniel Vetter, dri-devel, linux-kernel
On 04/12/2023 08:27, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A dependency on this feature was recently introduced:
>
> x86_64-linux-ld: vmlinux.o: in function `tc358768_bridge_pre_enable':
> tc358768.c:(.text+0xbe3dae): undefined reference to `drm_display_mode_to_videomode'
>
> Make sure this is always enabled.
>
> Fixes: e5fb21678136 ("drm/bridge: tc358768: Use struct videomode")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/bridge/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index ba82a1142adf..3e6a4e2044c0 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -313,6 +313,7 @@ config DRM_TOSHIBA_TC358768
> select REGMAP_I2C
> select DRM_PANEL
> select DRM_MIPI_DSI
> + select VIDEOMODE_HELPERS
> help
> Toshiba TC358768AXBG/TC358778XBG DSI bridge chip driver.
>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/bridge: tc358768: select CONFIG_VIDEOMODE_HELPERS
2023-12-04 7:27 [PATCH] drm/bridge: tc358768: select CONFIG_VIDEOMODE_HELPERS Arnd Bergmann
2023-12-04 9:55 ` Neil Armstrong
@ 2023-12-05 8:33 ` Neil Armstrong
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2023-12-05 8:33 UTC (permalink / raw)
To: Andrzej Hajda, Robert Foss, Peter Ujfalusi, Tomi Valkeinen,
Arnd Bergmann
Cc: Arnd Bergmann, Laurent Pinchart, Jonas Karlman, Jernej Skrabec,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann, David Airlie,
Daniel Vetter, dri-devel, linux-kernel
Hi,
On Mon, 04 Dec 2023 08:27:36 +0100, Arnd Bergmann wrote:
> A dependency on this feature was recently introduced:
>
> x86_64-linux-ld: vmlinux.o: in function `tc358768_bridge_pre_enable':
> tc358768.c:(.text+0xbe3dae): undefined reference to `drm_display_mode_to_videomode'
>
> Make sure this is always enabled.
>
> [...]
Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes)
[1/1] drm/bridge: tc358768: select CONFIG_VIDEOMODE_HELPERS
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=26513300978f7285c3e776c144f27ef71be61f57
--
Neil
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-12-05 8:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-04 7:27 [PATCH] drm/bridge: tc358768: select CONFIG_VIDEOMODE_HELPERS Arnd Bergmann
2023-12-04 9:55 ` Neil Armstrong
2023-12-05 8:33 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox