* [PATCH v2] iio: adc: ti_am335x_adc: Fix return value check of tiadc_request_dma()
@ 2023-09-25 13:44 Wadim Egorov
2023-10-05 14:09 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Wadim Egorov @ 2023-09-25 13:44 UTC (permalink / raw)
To: jic23, lars, robh, heiko, peter.ujfalusi, mugunthanvnm
Cc: linux-iio, linux-kernel, nm, upstream
Fix wrong handling of a DMA request where the probing only failed
if -EPROPE_DEFER was returned. Instead, let us fail if a non -ENODEV
value is returned. This makes DMAs explicitly optional. Even if the
DMA request is unsuccessfully, the ADC can still work properly.
We do also handle the defer probe case by making use of dev_err_probe().
Fixes: f438b9da75eb ("drivers: iio: ti_am335x_adc: add dma support")
Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
---
v2:
- Update description
- Drop line break after Fixes tag
- Move decision about optional DMA into probe/caller
---
drivers/iio/adc/ti_am335x_adc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c
index 8db7a01cb5fb..5f8795986995 100644
--- a/drivers/iio/adc/ti_am335x_adc.c
+++ b/drivers/iio/adc/ti_am335x_adc.c
@@ -670,8 +670,10 @@ static int tiadc_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, indio_dev);
err = tiadc_request_dma(pdev, adc_dev);
- if (err && err == -EPROBE_DEFER)
+ if (err && err != -ENODEV) {
+ dev_err_probe(&pdev->dev, err, "DMA request failed\n");
goto err_dma;
+ }
return 0;
--
2.34.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] iio: adc: ti_am335x_adc: Fix return value check of tiadc_request_dma()
2023-09-25 13:44 [PATCH v2] iio: adc: ti_am335x_adc: Fix return value check of tiadc_request_dma() Wadim Egorov
@ 2023-10-05 14:09 ` Jonathan Cameron
2023-11-24 12:11 ` Wadim Egorov
2023-11-27 9:40 ` Bhavya Kapoor
0 siblings, 2 replies; 6+ messages in thread
From: Jonathan Cameron @ 2023-10-05 14:09 UTC (permalink / raw)
To: Wadim Egorov
Cc: lars, robh, heiko, peter.ujfalusi, mugunthanvnm, linux-iio,
linux-kernel, nm, upstream, Bhavya Kapoor
On Mon, 25 Sep 2023 15:44:27 +0200
Wadim Egorov <w.egorov@phytec.de> wrote:
> Fix wrong handling of a DMA request where the probing only failed
> if -EPROPE_DEFER was returned. Instead, let us fail if a non -ENODEV
> value is returned. This makes DMAs explicitly optional. Even if the
> DMA request is unsuccessfully, the ADC can still work properly.
> We do also handle the defer probe case by making use of dev_err_probe().
>
> Fixes: f438b9da75eb ("drivers: iio: ti_am335x_adc: add dma support")
> Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
+CC Bhavya,
Could you take a look at this given you had comments on v1.
Thanks,
Jonathan
> ---
> v2:
> - Update description
> - Drop line break after Fixes tag
> - Move decision about optional DMA into probe/caller
> ---
> drivers/iio/adc/ti_am335x_adc.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c
> index 8db7a01cb5fb..5f8795986995 100644
> --- a/drivers/iio/adc/ti_am335x_adc.c
> +++ b/drivers/iio/adc/ti_am335x_adc.c
> @@ -670,8 +670,10 @@ static int tiadc_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, indio_dev);
>
> err = tiadc_request_dma(pdev, adc_dev);
> - if (err && err == -EPROBE_DEFER)
> + if (err && err != -ENODEV) {
> + dev_err_probe(&pdev->dev, err, "DMA request failed\n");
> goto err_dma;
> + }
>
> return 0;
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] iio: adc: ti_am335x_adc: Fix return value check of tiadc_request_dma()
2023-10-05 14:09 ` Jonathan Cameron
@ 2023-11-24 12:11 ` Wadim Egorov
2023-11-27 9:44 ` Bhavya Kapoor
2023-11-27 9:40 ` Bhavya Kapoor
1 sibling, 1 reply; 6+ messages in thread
From: Wadim Egorov @ 2023-11-24 12:11 UTC (permalink / raw)
To: Jonathan Cameron
Cc: lars, robh, heiko, peter.ujfalusi, mugunthanvnm, linux-iio,
linux-kernel, nm, upstream, Bhavya Kapoor
Am 05.10.23 um 16:09 schrieb Jonathan Cameron:
> On Mon, 25 Sep 2023 15:44:27 +0200
> Wadim Egorov <w.egorov@phytec.de> wrote:
>
>> Fix wrong handling of a DMA request where the probing only failed
>> if -EPROPE_DEFER was returned. Instead, let us fail if a non -ENODEV
>> value is returned. This makes DMAs explicitly optional. Even if the
>> DMA request is unsuccessfully, the ADC can still work properly.
>> We do also handle the defer probe case by making use of dev_err_probe().
>>
>> Fixes: f438b9da75eb ("drivers: iio: ti_am335x_adc: add dma support")
>> Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
> +CC Bhavya,
>
> Could you take a look at this given you had comments on v1.
Bhavya, any comments on this?
If not, is there anything else that is blocking this patch?
Regards,
Wadim
>
> Thanks,
>
> Jonathan
>
>> ---
>> v2:
>> - Update description
>> - Drop line break after Fixes tag
>> - Move decision about optional DMA into probe/caller
>> ---
>> drivers/iio/adc/ti_am335x_adc.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c
>> index 8db7a01cb5fb..5f8795986995 100644
>> --- a/drivers/iio/adc/ti_am335x_adc.c
>> +++ b/drivers/iio/adc/ti_am335x_adc.c
>> @@ -670,8 +670,10 @@ static int tiadc_probe(struct platform_device *pdev)
>> platform_set_drvdata(pdev, indio_dev);
>>
>> err = tiadc_request_dma(pdev, adc_dev);
>> - if (err && err == -EPROBE_DEFER)
>> + if (err && err != -ENODEV) {
>> + dev_err_probe(&pdev->dev, err, "DMA request failed\n");
>> goto err_dma;
>> + }
>>
>> return 0;
>>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] iio: adc: ti_am335x_adc: Fix return value check of tiadc_request_dma()
2023-11-24 12:11 ` Wadim Egorov
@ 2023-11-27 9:44 ` Bhavya Kapoor
2023-12-04 9:33 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Bhavya Kapoor @ 2023-11-27 9:44 UTC (permalink / raw)
To: Wadim Egorov, Jonathan Cameron
Cc: lars, robh, heiko, peter.ujfalusi, mugunthanvnm, linux-iio,
linux-kernel, nm, upstream
LGTM !!🙂
On 24/11/23 5:41 pm, Wadim Egorov wrote:
>
> Am 05.10.23 um 16:09 schrieb Jonathan Cameron:
>> On Mon, 25 Sep 2023 15:44:27 +0200
>> Wadim Egorov <w.egorov@phytec.de> wrote:
>>
>>> Fix wrong handling of a DMA request where the probing only failed
>>> if -EPROPE_DEFER was returned. Instead, let us fail if a non -ENODEV
>>> value is returned. This makes DMAs explicitly optional. Even if the
>>> DMA request is unsuccessfully, the ADC can still work properly.
>>> We do also handle the defer probe case by making use of
>>> dev_err_probe().
>>>
>>> Fixes: f438b9da75eb ("drivers: iio: ti_am335x_adc: add dma support")
>>> Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
Reviewed-by: Bhavya Kapoor <b-kapoor@ti.com>
>> +CC Bhavya,
>>
>> Could you take a look at this given you had comments on v1.
>
> Bhavya, any comments on this?
> If not, is there anything else that is blocking this patch?
>
> Regards,
> Wadim
>
>>
>> Thanks,
>>
>> Jonathan
>>
>>> ---
>>> v2:
>>> - Update description
>>> - Drop line break after Fixes tag
>>> - Move decision about optional DMA into probe/caller
>>> ---
>>> drivers/iio/adc/ti_am335x_adc.c | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/iio/adc/ti_am335x_adc.c
>>> b/drivers/iio/adc/ti_am335x_adc.c
>>> index 8db7a01cb5fb..5f8795986995 100644
>>> --- a/drivers/iio/adc/ti_am335x_adc.c
>>> +++ b/drivers/iio/adc/ti_am335x_adc.c
>>> @@ -670,8 +670,10 @@ static int tiadc_probe(struct platform_device
>>> *pdev)
>>> platform_set_drvdata(pdev, indio_dev);
>>> err = tiadc_request_dma(pdev, adc_dev);
>>> - if (err && err == -EPROBE_DEFER)
>>> + if (err && err != -ENODEV) {
>>> + dev_err_probe(&pdev->dev, err, "DMA request failed\n");
>>> goto err_dma;
>>> + }
>>> return 0;
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] iio: adc: ti_am335x_adc: Fix return value check of tiadc_request_dma()
2023-11-27 9:44 ` Bhavya Kapoor
@ 2023-12-04 9:33 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2023-12-04 9:33 UTC (permalink / raw)
To: Bhavya Kapoor
Cc: Wadim Egorov, lars, robh, heiko, peter.ujfalusi, mugunthanvnm,
linux-iio, linux-kernel, nm, upstream
On Mon, 27 Nov 2023 15:14:29 +0530
Bhavya Kapoor <b-kapoor@ti.com> wrote:
> LGTM !!🙂
>
> On 24/11/23 5:41 pm, Wadim Egorov wrote:
> >
> > Am 05.10.23 um 16:09 schrieb Jonathan Cameron:
> >> On Mon, 25 Sep 2023 15:44:27 +0200
> >> Wadim Egorov <w.egorov@phytec.de> wrote:
> >>
> >>> Fix wrong handling of a DMA request where the probing only failed
> >>> if -EPROPE_DEFER was returned. Instead, let us fail if a non -ENODEV
> >>> value is returned. This makes DMAs explicitly optional. Even if the
> >>> DMA request is unsuccessfully, the ADC can still work properly.
> >>> We do also handle the defer probe case by making use of
> >>> dev_err_probe().
> >>>
> >>> Fixes: f438b9da75eb ("drivers: iio: ti_am335x_adc: add dma support")
> >>> Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
> Reviewed-by: Bhavya Kapoor <b-kapoor@ti.com>
Applied to the fixes-togreg branch of iio.git and marked for stable.
> >> +CC Bhavya,
> >>
> >> Could you take a look at this given you had comments on v1.
> >
> > Bhavya, any comments on this?
> > If not, is there anything else that is blocking this patch?
> >
> > Regards,
> > Wadim
> >
> >>
> >> Thanks,
> >>
> >> Jonathan
> >>
> >>> ---
> >>> v2:
> >>> - Update description
> >>> - Drop line break after Fixes tag
> >>> - Move decision about optional DMA into probe/caller
> >>> ---
> >>> drivers/iio/adc/ti_am335x_adc.c | 4 +++-
> >>> 1 file changed, 3 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/drivers/iio/adc/ti_am335x_adc.c
> >>> b/drivers/iio/adc/ti_am335x_adc.c
> >>> index 8db7a01cb5fb..5f8795986995 100644
> >>> --- a/drivers/iio/adc/ti_am335x_adc.c
> >>> +++ b/drivers/iio/adc/ti_am335x_adc.c
> >>> @@ -670,8 +670,10 @@ static int tiadc_probe(struct platform_device
> >>> *pdev)
> >>> platform_set_drvdata(pdev, indio_dev);
> >>> err = tiadc_request_dma(pdev, adc_dev);
> >>> - if (err && err == -EPROBE_DEFER)
> >>> + if (err && err != -ENODEV) {
> >>> + dev_err_probe(&pdev->dev, err, "DMA request failed\n");
> >>> goto err_dma;
> >>> + }
> >>> return 0;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] iio: adc: ti_am335x_adc: Fix return value check of tiadc_request_dma()
2023-10-05 14:09 ` Jonathan Cameron
2023-11-24 12:11 ` Wadim Egorov
@ 2023-11-27 9:40 ` Bhavya Kapoor
1 sibling, 0 replies; 6+ messages in thread
From: Bhavya Kapoor @ 2023-11-27 9:40 UTC (permalink / raw)
To: Jonathan Cameron, Wadim Egorov
Cc: lars, robh, heiko, peter.ujfalusi, mugunthanvnm, linux-iio,
linux-kernel, nm, upstream
On 05/10/23 7:39 pm, Jonathan Cameron wrote:
> On Mon, 25 Sep 2023 15:44:27 +0200
> Wadim Egorov <w.egorov@phytec.de> wrote:
>
>> Fix wrong handling of a DMA request where the probing only failed
>> if -EPROPE_DEFER was returned. Instead, let us fail if a non -ENODEV
>> value is returned. This makes DMAs explicitly optional. Even if the
>> DMA request is unsuccessfully, the ADC can still work properly.
>> We do also handle the defer probe case by making use of dev_err_probe().
>>
>> Fixes: f438b9da75eb ("drivers: iio: ti_am335x_adc: add dma support")
>> Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
> +CC Bhavya,
>
> Could you take a look at this given you had comments on v1.
>
> Thanks,
>
> Jonathan
Hi Jonathan, Patch Looks Good To Me and Should now work fine for every case.
Regards
~B-Kapoor
>
>> ---
>> v2:
>> - Update description
>> - Drop line break after Fixes tag
>> - Move decision about optional DMA into probe/caller
>> ---
>> drivers/iio/adc/ti_am335x_adc.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/adc/ti_am335x_adc.c b/drivers/iio/adc/ti_am335x_adc.c
>> index 8db7a01cb5fb..5f8795986995 100644
>> --- a/drivers/iio/adc/ti_am335x_adc.c
>> +++ b/drivers/iio/adc/ti_am335x_adc.c
>> @@ -670,8 +670,10 @@ static int tiadc_probe(struct platform_device *pdev)
>> platform_set_drvdata(pdev, indio_dev);
>>
>> err = tiadc_request_dma(pdev, adc_dev);
>> - if (err && err == -EPROBE_DEFER)
>> + if (err && err != -ENODEV) {
>> + dev_err_probe(&pdev->dev, err, "DMA request failed\n");
>> goto err_dma;
>> + }
>>
>> return 0;
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-12-04 9:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-25 13:44 [PATCH v2] iio: adc: ti_am335x_adc: Fix return value check of tiadc_request_dma() Wadim Egorov
2023-10-05 14:09 ` Jonathan Cameron
2023-11-24 12:11 ` Wadim Egorov
2023-11-27 9:44 ` Bhavya Kapoor
2023-12-04 9:33 ` Jonathan Cameron
2023-11-27 9:40 ` Bhavya Kapoor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox