From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Linus Walleij <linus.walleij@linaro.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH v3 00/10] gpio/pinctrl: replace gpiochip_is_requested() with a safer interface
Date: Mon, 4 Dec 2023 10:34:59 +0100 [thread overview]
Message-ID: <20231204093509.19225-1-brgl@bgdev.pl> (raw)
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
While reworking the locking in GPIOLIB I realized that locking the
descriptor with users still calling gpiochip_is_requested() will still
be buggy as it returns a pointer to a string that can be freed whenever
the descriptor is released. Let's provide a safer alternative in the
form of a function that returns a copy of the label.
Use it in all drivers and remove gpiochip_is_requested().
I plan to provide this series in an immutable branch for the pinctrl and
baytrail trees to pull.
v2 -> v3:
- rename a local variable cpy -> copy
- use unsigned int to loop over GPIO lines
- use an unscoped guard in patch 10/10 instead of the scoped variant
v1 -> v2:
- use DEFINE_CLASS() to register a destructor for making sure that the
duplicated label doesn't leak out of the for_each loops even with
break;
Bartosz Golaszewski (10):
gpiolib: provide gpiochip_dup_line_label()
gpio: wm831x: use gpiochip_dup_line_label()
gpio: wm8994: use gpiochip_dup_line_label()
gpio: stmpe: use gpiochip_dup_line_label()
pinctrl: abx500: use gpiochip_dup_line_label()
pinctrl: nomadik: use gpiochip_dup_line_label()
pinctrl: baytrail: use gpiochip_dup_line_label()
pinctrl: sppctl: use gpiochip_dup_line_label()
gpiolib: use gpiochip_dup_line_label() in for_each helpers
gpiolib: remove gpiochip_is_requested()
drivers/gpio/gpio-stmpe.c | 6 +++-
drivers/gpio/gpio-wm831x.c | 14 +++++---
drivers/gpio/gpio-wm8994.c | 13 +++++---
drivers/gpio/gpiolib.c | 35 ++++++++++++--------
drivers/pinctrl/intel/pinctrl-baytrail.c | 11 ++++---
drivers/pinctrl/nomadik/pinctrl-abx500.c | 9 ++++--
drivers/pinctrl/nomadik/pinctrl-nomadik.c | 6 +++-
drivers/pinctrl/sunplus/sppctl.c | 10 +++---
include/linux/gpio/driver.h | 39 +++++++++++++++++------
9 files changed, 96 insertions(+), 47 deletions(-)
--
2.40.1
next reply other threads:[~2023-12-04 9:35 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 9:34 Bartosz Golaszewski [this message]
2023-12-04 9:35 ` [PATCH v3 01/10] gpiolib: provide gpiochip_dup_line_label() Bartosz Golaszewski
2023-12-04 9:35 ` [PATCH v3 02/10] gpio: wm831x: use gpiochip_dup_line_label() Bartosz Golaszewski
2023-12-04 13:16 ` Andy Shevchenko
2023-12-04 13:38 ` Bartosz Golaszewski
2023-12-04 9:35 ` [PATCH v3 03/10] gpio: wm8994: " Bartosz Golaszewski
2023-12-04 9:35 ` [PATCH v3 04/10] gpio: stmpe: " Bartosz Golaszewski
2023-12-04 9:35 ` [PATCH v3 05/10] pinctrl: abx500: " Bartosz Golaszewski
2023-12-04 9:35 ` [PATCH v3 06/10] pinctrl: nomadik: " Bartosz Golaszewski
2023-12-04 9:35 ` [PATCH v3 07/10] pinctrl: baytrail: " Bartosz Golaszewski
2023-12-04 13:18 ` Andy Shevchenko
2023-12-04 13:38 ` Bartosz Golaszewski
2023-12-04 9:35 ` [PATCH v3 08/10] pinctrl: sppctl: " Bartosz Golaszewski
2023-12-04 9:35 ` [PATCH v3 09/10] gpiolib: use gpiochip_dup_line_label() in for_each helpers Bartosz Golaszewski
2023-12-04 13:24 ` Andy Shevchenko
2023-12-04 13:39 ` Bartosz Golaszewski
2023-12-04 9:35 ` [PATCH v3 10/10] gpiolib: remove gpiochip_is_requested() Bartosz Golaszewski
2023-12-04 13:22 ` Andy Shevchenko
2023-12-05 22:49 ` [PATCH v3 00/10] gpio/pinctrl: replace gpiochip_is_requested() with a safer interface Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231204093509.19225-1-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bartosz.golaszewski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox