From: Kees Cook <keescook@chromium.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Song Liu <song@kernel.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-raid@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] md/md-multipath: Convert "struct mpconf" to flexible array
Date: Mon, 4 Dec 2023 14:20:04 -0800 [thread overview]
Message-ID: <202312041419.81EF03F7B7@keescook> (raw)
In-Reply-To: <03dd7de1cecdb7084814f2fab300c9bc716aff3e.1701632867.git.christophe.jaillet@wanadoo.fr>
On Sun, Dec 03, 2023 at 08:48:06PM +0100, Christophe JAILLET wrote:
> The 'multipaths' field of 'struct mpconf' can be declared as a flexible
> array.
>
> The advantages are:
> - 1 less indirection when accessing to the 'multipaths' array
> - save 1 pointer in the structure
> - improve memory usage
> - give the opportunity to use __counted_by() for additional safety
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
This looks like a really nice conversion. I haven't run-tested this, but
it reads correct to me.
Reviewed-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2023-12-04 22:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-03 19:48 [PATCH] md/md-multipath: Convert "struct mpconf" to flexible array Christophe JAILLET
2023-12-04 22:20 ` Kees Cook [this message]
2023-12-08 5:33 ` Song Liu
2023-12-08 17:27 ` Kees Cook
2023-12-08 18:11 ` Song Liu
2023-12-12 5:46 ` Christoph Hellwig
2023-12-12 7:46 ` Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202312041419.81EF03F7B7@keescook \
--to=keescook@chromium.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gustavoars@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox