From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02CBAC4167B for ; Tue, 5 Dec 2023 02:52:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376508AbjLECwG (ORCPT ); Mon, 4 Dec 2023 21:52:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344119AbjLECwF (ORCPT ); Mon, 4 Dec 2023 21:52:05 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 701E6BF for ; Mon, 4 Dec 2023 18:52:12 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7CE33C433C7; Tue, 5 Dec 2023 02:52:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701744732; bh=EdPT0D7iQR/UUGO665qQNSALpBEJ+4Q7yzIggGYt+IY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qEl86zg3qrkgdVwO1uWAQ0QtcHS86eAhjAyo3Ut2ID/fjR4NsfF1zNAhvKXSseiCp ppA7cOlhod8g9lYZt+hSF1pHHBfDxHhB5nuqsHOvJ2trZSPCPWW+LvLOzWCn30AOd3 smkPzXI57CHH9PjHLAPCFkANWCsuMeDT03stNBpgZUMEyBFVIpYdwgdTEp5vqzTYr9 KP8IRoU2g30RRmNvShYWSrlDaJh0dasDkShMwWMLTURdtIZGBp5MHKe446v0/EX6kt TJNmdQRWr8pRvoeg4BNAGczkU06qRgojqRlrUqkSzQDR+NglaSIv5rmpUkPbfyt7vV hcxWW9hnSer4w== Date: Mon, 4 Dec 2023 18:52:10 -0800 From: Jakub Kicinski To: Aron Silverton Cc: Greg Kroah-Hartman , Saeed Mahameed , Jason Gunthorpe , David Ahern , Arnd Bergmann , Leon Romanovsky , Jiri Pirko , Leonid Bloch , Itay Avraham , linux-kernel@vger.kernel.org, Saeed Mahameed Subject: Re: [PATCH V3 2/5] misc: mlx5ctl: Add mlx5ctl misc driver Message-ID: <20231204185210.030a72ca@kernel.org> In-Reply-To: References: <20231127160719.4a8b2ad1@kernel.org> <20231128044628.GA8901@u2004-local> <20231128065321.53d4d5bb@kernel.org> <20231128162413.GP436702@nvidia.com> <20231128084421.6321b9b2@kernel.org> <20231128175224.GR436702@nvidia.com> <20231128103304.25c2c642@kernel.org> <2023112922-lyricist-unclip-8e78@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 4 Dec 2023 15:37:56 -0600 Aron Silverton wrote: > > To Jakub's point, no, we don't care about enterprise distros, they are a > > consumer of our releases and while some of them pay the salaries of our > > developers, they really don't have much influence over our development > > rules as they are just so far behind in releases that their releases > > look nothing like what we do in places (i.e. Linux "like" just like many > > Android systems.) > > > > If the enterprise distros pop in here and give us their opinions of the > > patchset, I would GREATLY appreciate it, as having more people review > > code at this point in time would be most helpful instead of having to > > hear about how the interfaces are broken 2 years from now. > > We will be happy to test and review v4 of this series. > > Fully interactive debugging has become essential to getting to the root > cause of complex issues that arise between the types of devices being > discussed and their interactions with various software layers. Turning > knobs and dumping registers just isn't sufficient, and I wish we'd had > this capability long ago. Could you shed some light on what issues you were debugging, broadly? > Our customers have already benefited from the interactive debugging > capability that these patches provide, but the full potential won't be > realized until this is upstream. Can you elaborate on why "full potential won't be realized until this is upstream"? The driver looks very easy to ship as a standalone module.