From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9F90C10DC3 for ; Mon, 4 Dec 2023 22:27:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231485AbjLDW1c convert rfc822-to-8bit (ORCPT ); Mon, 4 Dec 2023 17:27:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230461AbjLDW13 (ORCPT ); Mon, 4 Dec 2023 17:27:29 -0500 Received: from mail.andi.de1.cc (mail.andi.de1.cc [IPv6:2a02:c205:3004:2154::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0D4285; Mon, 4 Dec 2023 14:27:34 -0800 (PST) Received: from p200301077700c3001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:107:7700:c300:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rAHPS-0071Vx-0b; Mon, 04 Dec 2023 23:27:26 +0100 Date: Mon, 4 Dec 2023 23:27:22 +0100 From: Andreas Kemnade To: Adam Ford Cc: lee@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, bcousson@baylibre.com, tony@atomide.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org Subject: Re: [PATCH v3 6/6] ARM: dts: omap: gta04: standardize system-power-controller Message-ID: <20231204232722.031f618c@aktux> In-Reply-To: References: <20231203222903.343711-1-andreas@kemnade.info> <20231203222903.343711-7-andreas@kemnade.info> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 3 Dec 2023 16:46:20 -0600 Adam Ford wrote: > On Sun, Dec 3, 2023 at 4:29 PM Andreas Kemnade wrote: > > > > Replace TI-specific property by generic one. > > > > Signed-off-by: Andreas Kemnade > > --- > > cannot be applied independently of the other ones, so maybe simply delay > > it. > > > > arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi b/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi > > index 3661340009e7a..5001c4ea35658 100644 > > --- a/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi > > +++ b/arch/arm/boot/dts/ti/omap/omap3-gta04.dtsi > > @@ -476,6 +476,7 @@ twl: twl@48 { > > reg = <0x48>; > > interrupts = <7>; /* SYS_NIRQ cascaded to intc */ > > interrupt-parent = <&intc>; > > + system-power-controller; > > Could this go into the twl4030.dtsi file so we don't have every omap3 > board with this part duplicating this line? > Well, that is a board-specific issue, so I do not think it belongs there, although quite common to have the twl4030 as the system-power-controller. Regards, Andreas