From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81D47C4167B for ; Mon, 4 Dec 2023 12:22:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233079AbjLDMWO (ORCPT ); Mon, 4 Dec 2023 07:22:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229532AbjLDMWM (ORCPT ); Mon, 4 Dec 2023 07:22:12 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA402FF for ; Mon, 4 Dec 2023 04:22:18 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 282F2C433C7; Mon, 4 Dec 2023 12:22:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1701692538; bh=pzjF4BiZqDIILVuK6wtq+QRLEZJMUkFd/A1HbQe9doo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JhjQhDYiq+QfWkSXH7X+Aw3zPQoZ31scwTt/oRP2n9WLBgi7hpxU0qfZ6Jp+K1yUB CgK0nP2oZDFco3kXqGYjDjMkAgwPp+hNOBsuyRTusUnygF0uJf/n2lG1CLGQHcpAOo nzqAeXF+t8eIYDDdg9zsESqeyWQm7JyDjqfn8HGk= Date: Mon, 4 Dec 2023 08:20:59 +0100 From: Greg Kroah-Hartman To: Max Kellermann Cc: Tejun Heo , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] fs/kernfs/dir: obey S_ISGID Message-ID: <2023120424-siren-catlike-eb00@gregkh> References: <20231201125638.1699026-1-max.kellermann@ionos.com> <20231201125638.1699026-2-max.kellermann@ionos.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231201125638.1699026-2-max.kellermann@ionos.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 01, 2023 at 01:56:38PM +0100, Max Kellermann wrote: > Handling of S_ISGID is usually done by inode_init_owner() in all other > filesystems, but kernfs doesn't use that function. In kernfs, struct > kernfs_node is the primary data structure, and struct inode is only > created from it on demand. Therefore, inode_init_owner() can't be > used and we need to imitate its behavior. > > S_ISGID support is useful for the cgroup filesystem; it allows > subtrees managed by an unprivileged process to retain a certain owner > gid, which then enables sharing access to the subtree with another > unprivileged process. > > Signed-off-by: Max Kellermann > --- > fs/kernfs/dir.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) I only see patch 2/2 here, what happened to patch 1/2? Please send them as a full series, otherwise I don't know what to do with just this one. thanks, greg k-h