From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 819BAC4167B for ; Mon, 4 Dec 2023 13:18:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233767AbjLDNR4 (ORCPT ); Mon, 4 Dec 2023 08:17:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43860 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229711AbjLDNRy (ORCPT ); Mon, 4 Dec 2023 08:17:54 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A87DAC for ; Mon, 4 Dec 2023 05:18:01 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CAE7C433C7; Mon, 4 Dec 2023 13:18:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1701695880; bh=ZqsFtctKz9KtHBVaOAU2TTpWyjElrfSFoJLOxIVMTBw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=V3CqwlbsqEox3O49weyGdcQgKaT/vva39nClwrr0CpCRY2g3pjXHrIasnDELtAzg+ sAb05PUuBlSLobzbT5w2mwA4s5YNFxoxQ29uJ5QK7wKqXw6ck98VVV94DcMJcBcp4m saMkFkQUWPsmS1A7nJ5Fb28oF86lN5vZ2FitGqKA= Date: Mon, 4 Dec 2023 22:17:58 +0900 From: Greg KH To: Dan Carpenter Cc: Su Hui , alexander.usyskin@intel.com, tomas.winkler@intel.com, arnd@arndb.de, nathan@kernel.org, ndesaulniers@google.com, trix@redhat.com, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v3] misc: mei: client.c: fix problem of return '-EOVERFLOW' in mei_cl_write Message-ID: <2023120425-broaden-image-fdc9@gregkh> References: <20231128014507.418254-1-suhui@nfschina.com> <2023120452-stool-party-bf2b@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 04, 2023 at 04:11:31PM +0300, Dan Carpenter wrote: > On Mon, Dec 04, 2023 at 09:00:42AM +0100, Greg KH wrote: > > > diff --git a/drivers/misc/mei/client.c b/drivers/misc/mei/client.c > > > index 7ea80779a0e2..0489bec4fded 100644 > > > --- a/drivers/misc/mei/client.c > > > +++ b/drivers/misc/mei/client.c > > > @@ -2033,7 +2033,7 @@ ssize_t mei_cl_write(struct mei_cl *cl, struct mei_cl_cb *cb, unsigned long time > > > hbuf_slots = mei_hbuf_empty_slots(dev); > > > if (hbuf_slots < 0) { > > > rets = -EOVERFLOW; > > > - goto out; > > > + goto err; > > > > Please prove that this is correct, as based on the code logic, it seems > > very wrong. I can't take this unless the code is tested properly. > > Hi Greg, > > When Su Hui sent the v2 patch you sent an auto response about adding > stable to the CC list. > https://lore.kernel.org/all/2023112042-napped-snoring-b766@gregkh/ > > However, it appears that you still applied the v2 patch. It's in > linux-next as commit ee6236027218 ("misc: mei: client.c: fix problem of > return '-EOVERFLOW' in mei_cl_write"). > > When I use `git am` to apply this patch, then it doesn't apply. However, > when I use cat email.txt | patch -p1 then it tries to reverse the patch > and apply it to a different function. Odd, I missed that I had already applied the first one, nevermind, that one is correct, this one was wrong :) thanks, greg k-h