Re: [PATCH 2/4] mm: hugetlb_vmemmap: use walk_page_range_novma() to simplify the code

Mike Kravetz
2023-12-04T22:54:30Z

On 11/27/23 16:46, Muchun Song wrote:
> It is unnecessary to implement a series of dedicated page table walking
> helpers since there is already a general one walk_page_range_novma().
> So use it to simplify the code.

That is a very nice cleanup!
Much code is removed, but I could not find any issues.

> Signed-off-by: Muchun Song <songmuchun@bytedance.com>
> ---
> mm/hugetlb_vmemmap.c | 148 ++++++++++++-------------------------------
> 1 file changed, 39 insertions(+), 109 deletions(-)

Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz