Re: [PATCH net-next 11/16] net: pcs: xpcs: Change xpcs_create_mdiodev() suffix to "byaddr"

kernel test robot
2023-12-05T23:05:05Z

Hi Serge,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url: https://github.com/intel-lab-lkp/linux/commits/Serge-Semin/net-pcs-xpcs-Drop-sentinel-entry-from-2500basex-ifaces-list/20231205-183808
base: net-next/main
patch link: https://lore.kernel.org/r/20231205103559.9605-12-fancer.lancer%40gmail.com
patch subject: [PATCH net-next 11/16] net: pcs: xpcs: Change xpcs_create_mdiodev() suffix to "byaddr"
config: arc-randconfig-001-20231206 (https://download.01.org/0day-ci/archive/20231206/202312060634.Cblfigt2-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231206/202312060634.Cblfigt2-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312060634.Cblfigt2-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c: In function 'txgbe_mdio_pcs_init':
>> drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c:150:16: error: implicit declaration of function 'xpcs_create_mdiodev'; did you mean 'xpcs_create_byaddr'? [-Werror=implicit-function-declaration]
150 | xpcs = xpcs_create_mdiodev(mii_bus, 0, PHY_INTERFACE_MODE_10GBASER);
| ^~~~~~~~~~~~~~~~~~~
| xpcs_create_byaddr
>> drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c:150:14: warning: assignment to 'struct dw_xpcs *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
150 | xpcs = xpcs_create_mdiodev(mii_bus, 0, PHY_INTERFACE_MODE_10GBASER);
| ^
cc1: some warnings being treated as errors

vim +150 drivers/net/ethernet/wangxun/txgbe/txgbe_phy.c

854cace61387b6 Jiawen Wu 2023-06-06 121
854cace61387b6 Jiawen Wu 2023-06-06 122 static int txgbe_mdio_pcs_init(struct txgbe *txgbe)
854cace61387b6 Jiawen Wu 2023-06-06 123 {
854cace61387b6 Jiawen Wu 2023-06-06 124 struct mii_bus *mii_bus;
854cace61387b6 Jiawen Wu 2023-06-06 125 struct dw_xpcs *xpcs;
854cace61387b6 Jiawen Wu 2023-06-06 126 struct pci_dev *pdev;
854cace61387b6 Jiawen Wu 2023-06-06 127 struct wx *wx;
854cace61387b6 Jiawen Wu 2023-06-06 128 int ret = 0;
854cace61387b6 Jiawen Wu 2023-06-06 129
854cace61387b6 Jiawen Wu 2023-06-06 130 wx = txgbe->wx;
854cace61387b6 Jiawen Wu 2023-06-06 131 pdev = wx->pdev;
854cace61387b6 Jiawen Wu 2023-06-06 132
854cace61387b6 Jiawen Wu 2023-06-06 133 mii_bus = devm_mdiobus_alloc(&pdev->dev);
854cace61387b6 Jiawen Wu 2023-06-06 134 if (!mii_bus)
854cace61387b6 Jiawen Wu 2023-06-06 135 return -ENOMEM;
854cace61387b6 Jiawen Wu 2023-06-06 136
854cace61387b6 Jiawen Wu 2023-06-06 137 mii_bus->name = "txgbe_pcs_mdio_bus";
854cace61387b6 Jiawen Wu 2023-06-06 138 mii_bus->read_c45 = &txgbe_pcs_read;
854cace61387b6 Jiawen Wu 2023-06-06 139 mii_bus->write_c45 = &txgbe_pcs_write;
854cace61387b6 Jiawen Wu 2023-06-06 140 mii_bus->parent = &pdev->dev;
854cace61387b6 Jiawen Wu 2023-06-06 141 mii_bus->phy_mask = ~0;
854cace61387b6 Jiawen Wu 2023-06-06 142 mii_bus->priv = wx;
854cace61387b6 Jiawen Wu 2023-06-06 143 snprintf(mii_bus->id, MII_BUS_ID_SIZE, "txgbe_pcs-%x",
d8c21ef7b2b147 Xiongfeng Wang 2023-08-08 144 pci_dev_id(pdev));
854cace61387b6 Jiawen Wu 2023-06-06 145
854cace61387b6 Jiawen Wu 2023-06-06 146 ret = devm_mdiobus_register(&pdev->dev, mii_bus);
854cace61387b6 Jiawen Wu 2023-06-06 147 if (ret)
854cace61387b6 Jiawen Wu 2023-06-06 148 return ret;
854cace61387b6 Jiawen Wu 2023-06-06 149
854cace61387b6 Jiawen Wu 2023-06-06 @150 xpcs = xpcs_create_mdiodev(mii_bus, 0, PHY_INTERFACE_MODE_10GBASER);
854cace61387b6 Jiawen Wu 2023-06-06 151 if (IS_ERR(xpcs))
854cace61387b6 Jiawen Wu 2023-06-06 152 return PTR_ERR(xpcs);
854cace61387b6 Jiawen Wu 2023-06-06 153
854cace61387b6 Jiawen Wu 2023-06-06 154 txgbe->xpcs = xpcs;
854cace61387b6 Jiawen Wu 2023-06-06 155
854cace61387b6 Jiawen Wu 2023-06-06 156 return 0;
854cace61387b6 Jiawen Wu 2023-06-06 157 }
854cace61387b6 Jiawen Wu 2023-06-06 158

--
0-DAY CI Kernel Test Service