From: Boris Brezillon <boris.brezillon@collabora.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: robh@kernel.org, steven.price@arm.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
kernel@collabora.com, m.szyprowski@samsung.com,
krzysztof.kozlowski@linaro.org
Subject: Re: [PATCH v4 0/3] drm/panfrost: Fix poweroff and sync IRQs for suspend
Date: Tue, 5 Dec 2023 11:42:37 +0100 [thread overview]
Message-ID: <20231205114237.72c69160@collabora.com> (raw)
In-Reply-To: <20231204114215.54575-1-angelogioacchino.delregno@collabora.com>
On Mon, 4 Dec 2023 12:42:12 +0100
AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
wrote:
> Changes in v4:
> - Added checks for is_suspended bits in hardirqs
> - Added GPU suspended bit (and handling of it)
> - Reordered panfrost_drv_comp_bits entries
> - Commit description fixes
>
> Changes in v3:
> - Removed useless GPU_INT_CLEAR write in suspend path
> - Changed to clear suspend bits in job/mmu reset path
>
> This series contains a fast fix for the basic GPU poweroff functionality
> and goes further by implementing interrupt masking and synchronization
> before suspend.
>
> For more information, please look at the conversation at [1], which
> explains the regression seen with the poweroff commit and the initial
> approaches taken to solve that.
>
> Cheers!
>
> [1]: https://lore.kernel.org/all/20231123095320.41433-1-angelogioacchino.delregno@collabora.com/
>
> AngeloGioacchino Del Regno (3):
> drm/panfrost: Ignore core_mask for poweroff and disable PWRTRANS irq
> drm/panfrost: Add gpu_irq, mmu_irq to struct panfrost_device
> drm/panfrost: Synchronize and disable interrupts before powering off
Queued to drm-misc-next.
Thanks,
Boris
>
> drivers/gpu/drm/panfrost/panfrost_device.c | 3 ++
> drivers/gpu/drm/panfrost/panfrost_device.h | 10 ++++++
> drivers/gpu/drm/panfrost/panfrost_gpu.c | 40 ++++++++++++++++------
> drivers/gpu/drm/panfrost/panfrost_gpu.h | 1 +
> drivers/gpu/drm/panfrost/panfrost_job.c | 26 +++++++++++---
> drivers/gpu/drm/panfrost/panfrost_job.h | 1 +
> drivers/gpu/drm/panfrost/panfrost_mmu.c | 32 ++++++++++++-----
> drivers/gpu/drm/panfrost/panfrost_mmu.h | 1 +
> 8 files changed, 91 insertions(+), 23 deletions(-)
>
prev parent reply other threads:[~2023-12-05 10:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 11:42 [PATCH v4 0/3] drm/panfrost: Fix poweroff and sync IRQs for suspend AngeloGioacchino Del Regno
2023-12-04 11:42 ` [PATCH v4 1/3] drm/panfrost: Ignore core_mask for poweroff and disable PWRTRANS irq AngeloGioacchino Del Regno
2023-12-04 16:05 ` Marek Szyprowski
2023-12-04 11:42 ` [PATCH v4 2/3] drm/panfrost: Add gpu_irq, mmu_irq to struct panfrost_device AngeloGioacchino Del Regno
2023-12-04 16:05 ` Marek Szyprowski
2023-12-04 11:42 ` [PATCH v4 3/3] drm/panfrost: Synchronize and disable interrupts before powering off AngeloGioacchino Del Regno
2023-12-04 13:52 ` Boris Brezillon
2023-12-04 16:05 ` Marek Szyprowski
2023-12-04 16:34 ` Steven Price
2023-12-05 10:42 ` Boris Brezillon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231205114237.72c69160@collabora.com \
--to=boris.brezillon@collabora.com \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=steven.price@arm.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox