From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32AEEC4167B for ; Tue, 5 Dec 2023 21:44:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345918AbjLEVn6 (ORCPT ); Tue, 5 Dec 2023 16:43:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229591AbjLEVn4 (ORCPT ); Tue, 5 Dec 2023 16:43:56 -0500 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [IPv6:2a03:a000:7:0:5054:ff:fe1c:15ff]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1B63EB9; Tue, 5 Dec 2023 13:44:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Ob0/5+i/dplkA8aeloC30i9UVjoXlmEru6XWrA4njrk=; b=TJosacg92BzELf3f/C9b2mNlgW JS58+N92PYhSO0HC8MeVwNSmBt6jQw6sAc15OuEryEYCON3dY35drua95BjcpxFZRhgwrWDM9L0FQ rLtzbAH8sFvZ+xSdERvnJY+pAXgjsXC2XqDzQIlWowfJsCuUjd0p6MdfSJiVaByK6NEep7j+nWzrB QItb8tPCpIv0T6LuGMJMVR9WWwXl/8NnCBVfGTPjvX10koJnCnQP/xzQurWEGA7egS/IpwgeE6SC+ Ei5NZhfd3Rf2bUu9QJpTuER90O742ilR9Vn4GA11kYFRMsdzcxFUcsLFYLAPAN3k4X2vAL1tOrhH9 V/gZQ6zg==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1rAdCx-007TVQ-1R; Tue, 05 Dec 2023 21:43:59 +0000 Date: Tue, 5 Dec 2023 21:43:59 +0000 From: Al Viro To: Nick Desaulniers Cc: Andrew Morton , tanzirh@google.com, Kees Cook , Andy Shevchenko , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, Nick DeSaulniers , llvm@lists.linux.dev Subject: Re: [PATCH] lib/string: shrink lib/string.i via IWYU Message-ID: <20231205214359.GF1674809@ZenIV> References: <20231205-libstringheader-v1-1-7f9c573053a7@gmail.com> <20231205130449.8e330a26ecbed1f7b5ad5d7a@linux-foundation.org> <20231205132452.418722bea8f6878dca88142a@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 05, 2023 at 01:39:47PM -0800, Nick Desaulniers wrote: > The tooling Tanzir is working on does wrap IWYU, and does support such > mapping (of 'low level' to 'high level' headers; more so, if it > recommends X you can override to suggest Y instead). > > arch/nios/ also doesn't provide a bug.h, which this patch is > suggesting we include directly. I guess the same goes for > asm/rwonce.h. See include/asm-generic/Kbuild: mandatory-y += bug.h ... mandatory-y += rwonce.h IOW, sh will have asm/bug.h and as/rwonce.h copied from asm-generic. Still, includes of asm/*.h had been a massive headache historically and breeding more of those shouldn't be overdone. More painful problem is arch- and config-dependent stuff, though...