public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
To: gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Subject: [PATCH 01/27] tty: goldfish: use bool for is_write parameter
Date: Wed,  6 Dec 2023 08:36:46 +0100	[thread overview]
Message-ID: <20231206073712.17776-2-jirislaby@kernel.org> (raw)
In-Reply-To: <20231206073712.17776-1-jirislaby@kernel.org>

do_rw_io()'s is_write parameter is boolean, but typed int. Switch to the
former, so that it's obvious. (And the two users too.)

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
---
 drivers/tty/goldfish.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/tty/goldfish.c b/drivers/tty/goldfish.c
index dccf6c6c69c6..7ad7fa66cb27 100644
--- a/drivers/tty/goldfish.c
+++ b/drivers/tty/goldfish.c
@@ -53,7 +53,7 @@ static struct goldfish_tty *goldfish_ttys;
 static void do_rw_io(struct goldfish_tty *qtty,
 		     unsigned long address,
 		     unsigned int count,
-		     int is_write)
+		     bool is_write)
 {
 	unsigned long irq_flags;
 	void __iomem *base = qtty->base;
@@ -76,7 +76,7 @@ static void do_rw_io(struct goldfish_tty *qtty,
 static void goldfish_tty_rw(struct goldfish_tty *qtty,
 			    unsigned long addr,
 			    unsigned int count,
-			    int is_write)
+			    bool is_write)
 {
 	dma_addr_t dma_handle;
 	enum dma_data_direction dma_dir;
@@ -129,7 +129,7 @@ static void goldfish_tty_do_write(int line, const u8 *buf, unsigned int count)
 {
 	struct goldfish_tty *qtty = &goldfish_ttys[line];
 
-	goldfish_tty_rw(qtty, (unsigned long)buf, count, 1);
+	goldfish_tty_rw(qtty, (unsigned long)buf, count, true);
 }
 
 static irqreturn_t goldfish_tty_interrupt(int irq, void *dev_id)
@@ -145,7 +145,7 @@ static irqreturn_t goldfish_tty_interrupt(int irq, void *dev_id)
 
 	count = tty_prepare_flip_string(&qtty->port, &buf, count);
 
-	goldfish_tty_rw(qtty, (unsigned long)buf, count, 0);
+	goldfish_tty_rw(qtty, (unsigned long)buf, count, false);
 
 	tty_flip_buffer_push(&qtty->port);
 	return IRQ_HANDLED;
-- 
2.43.0


  reply	other threads:[~2023-12-06  7:37 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-06  7:36 [PATCH 00/27] tty: type unifications -- the last part Jiri Slaby (SUSE)
2023-12-06  7:36 ` Jiri Slaby (SUSE) [this message]
2023-12-06  7:36 ` [PATCH 02/27] tty: mmc: sdio_uart: switch sdio_in() to return u8 Jiri Slaby (SUSE)
2023-12-07 14:09   ` Ulf Hansson
2023-12-06  7:36 ` [PATCH 03/27] tty: switch tty_port::xmit_* to u8 Jiri Slaby (SUSE)
2023-12-06  7:36 ` [PATCH 04/27] tty: make tty_operations::send_xchar accept u8 char Jiri Slaby (SUSE)
2023-12-06  8:27   ` Geert Uytterhoeven
2023-12-07 14:09   ` Ulf Hansson
2023-12-06  7:36 ` [PATCH 05/27] tty: core: the rest to u8 Jiri Slaby (SUSE)
2023-12-06  7:36 ` [PATCH 06/27] tty: ami: use u8 for characters and flag Jiri Slaby (SUSE)
2023-12-06  8:28   ` Geert Uytterhoeven
2023-12-06  7:36 ` [PATCH 07/27] tty: bcm: convert to u8 and size_t Jiri Slaby (SUSE)
2023-12-06  7:36 ` [PATCH 08/27] tty: con3215: " Jiri Slaby (SUSE)
2023-12-08 13:19   ` Alexander Gordeev
2023-12-06  7:36 ` [PATCH 09/27] tty: con3270: " Jiri Slaby (SUSE)
2023-12-08 13:19   ` Alexander Gordeev
2023-12-06  7:36 ` [PATCH 10/27] tty: ehv_bytechan: " Jiri Slaby (SUSE)
2023-12-06  7:36 ` [PATCH 11/27] tty: goldfish: " Jiri Slaby (SUSE)
2023-12-06  7:36 ` [PATCH 12/27] tty: hvc: " Jiri Slaby (SUSE)
2023-12-06  9:30   ` Christophe Leroy
2023-12-06  7:36 ` [PATCH 13/27] tty: ipoctal: " Jiri Slaby (SUSE)
2023-12-06  7:36 ` [PATCH 14/27] tty: m68k: nfcon: " Jiri Slaby (SUSE)
2023-12-06  7:51   ` Geert Uytterhoeven
2023-12-06  7:37 ` [PATCH 15/27] tty: mips_ejtag_fdc: use u8 for character pointers Jiri Slaby (SUSE)
2023-12-06  7:37 ` [PATCH 16/27] tty: mmc: sdio: use u8 for flag Jiri Slaby (SUSE)
2023-12-07 14:10   ` Ulf Hansson
2023-12-06  7:37 ` [PATCH 17/27] tty: moxa: convert to u8 and size_t Jiri Slaby (SUSE)
2023-12-06  7:37 ` [PATCH 18/27] tty: mxser: " Jiri Slaby (SUSE)
2023-12-06  7:37 ` [PATCH 19/27] tty: n_gsm: " Jiri Slaby (SUSE)
2023-12-06  7:37 ` [PATCH 20/27] tty: n_hdlc: " Jiri Slaby (SUSE)
2023-12-06  7:37 ` [PATCH 21/27] tty: nozomi: " Jiri Slaby (SUSE)
2023-12-07 12:50   ` Ilpo Järvinen
2023-12-06  7:37 ` [PATCH 22/27] tty: serdev: convert to u8 and size_t in serdev_controller_ops Jiri Slaby (SUSE)
2023-12-06  7:37 ` [PATCH 23/27] tty: serdev: convert to u8 and size_t Jiri Slaby (SUSE)
2023-12-06  8:09   ` Johan Hovold
2023-12-07  1:47     ` Greg KH
2023-12-07  8:19       ` Johan Hovold
2023-12-07 10:09         ` Greg KH
2023-12-06  7:37 ` [PATCH 24/27] tty: srmcons: " Jiri Slaby (SUSE)
2023-12-06  7:37 ` [PATCH 25/27] tty: ttyprintk: " Jiri Slaby (SUSE)
2023-12-06  7:37 ` [PATCH 26/27] tty: um: convert to u8/__u8 " Jiri Slaby (SUSE)
2023-12-06  7:37 ` [PATCH 27/27] tty: xtensa/iss: use u8 Jiri Slaby (SUSE)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231206073712.17776-2-jirislaby@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox