public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
To: gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Subject: [PATCH 19/27] tty: n_gsm: convert to u8 and size_t
Date: Wed,  6 Dec 2023 08:37:04 +0100	[thread overview]
Message-ID: <20231206073712.17776-20-jirislaby@kernel.org> (raw)
In-Reply-To: <20231206073712.17776-1-jirislaby@kernel.org>

Switch character types to u8 and sizes to size_t. To conform to
characters/sizes in the rest of the tty layer.

Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
---
 drivers/tty/n_gsm.c | 17 ++++++++---------
 1 file changed, 8 insertions(+), 9 deletions(-)

diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index a3ab3946e4ad..4036566febcb 100644
--- a/drivers/tty/n_gsm.c
+++ b/drivers/tty/n_gsm.c
@@ -124,8 +124,8 @@ struct gsm_msg {
 	u8 addr;		/* DLCI address + flags */
 	u8 ctrl;		/* Control byte + flags */
 	unsigned int len;	/* Length of data block (can be zero) */
-	unsigned char *data;	/* Points into buffer but not at the start */
-	unsigned char buffer[];
+	u8 *data;	/* Points into buffer but not at the start */
+	u8 buffer[];
 };
 
 enum gsm_dlci_state {
@@ -283,7 +283,7 @@ struct gsm_mux {
 	/* Bits for GSM mode decoding */
 
 	/* Framing Layer */
-	unsigned char *buf;
+	u8 *buf;
 	enum gsm_mux_state state;
 	unsigned int len;
 	unsigned int address;
@@ -2856,7 +2856,7 @@ static void gsm_queue(struct gsm_mux *gsm)
  *	Receive bytes in gsm mode 0
  */
 
-static void gsm0_receive(struct gsm_mux *gsm, unsigned char c)
+static void gsm0_receive(struct gsm_mux *gsm, u8 c)
 {
 	unsigned int len;
 
@@ -2947,7 +2947,7 @@ static void gsm0_receive(struct gsm_mux *gsm, unsigned char c)
  *	Receive bytes in mode 1 (Advanced option)
  */
 
-static void gsm1_receive(struct gsm_mux *gsm, unsigned char c)
+static void gsm1_receive(struct gsm_mux *gsm, u8 c)
 {
 	/* handle XON/XOFF */
 	if ((c & ISO_IEC_646_MASK) == XON) {
@@ -3541,7 +3541,7 @@ static void gsmld_receive_buf(struct tty_struct *tty, const u8 *cp,
 			      const u8 *fp, size_t count)
 {
 	struct gsm_mux *gsm = tty->disc_data;
-	char flags = TTY_NORMAL;
+	u8 flags = TTY_NORMAL;
 
 	if (debug & DBG_DATA)
 		gsm_hex_dump_bytes(__func__, cp, count);
@@ -3711,7 +3711,7 @@ static ssize_t gsmld_write(struct tty_struct *tty, struct file *file,
 {
 	struct gsm_mux *gsm = tty->disc_data;
 	unsigned long flags;
-	int space;
+	size_t space;
 	int ret;
 
 	if (!gsm)
@@ -3909,8 +3909,7 @@ static void gsm_mux_net_tx_timeout(struct net_device *net, unsigned int txqueue)
 	net->stats.tx_errors++;
 }
 
-static void gsm_mux_rx_netchar(struct gsm_dlci *dlci,
-				const unsigned char *in_buf, int size)
+static void gsm_mux_rx_netchar(struct gsm_dlci *dlci, const u8 *in_buf, int size)
 {
 	struct net_device *net = dlci->net;
 	struct sk_buff *skb;
-- 
2.43.0


  parent reply	other threads:[~2023-12-06  7:39 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-06  7:36 [PATCH 00/27] tty: type unifications -- the last part Jiri Slaby (SUSE)
2023-12-06  7:36 ` [PATCH 01/27] tty: goldfish: use bool for is_write parameter Jiri Slaby (SUSE)
2023-12-06  7:36 ` [PATCH 02/27] tty: mmc: sdio_uart: switch sdio_in() to return u8 Jiri Slaby (SUSE)
2023-12-07 14:09   ` Ulf Hansson
2023-12-06  7:36 ` [PATCH 03/27] tty: switch tty_port::xmit_* to u8 Jiri Slaby (SUSE)
2023-12-06  7:36 ` [PATCH 04/27] tty: make tty_operations::send_xchar accept u8 char Jiri Slaby (SUSE)
2023-12-06  8:27   ` Geert Uytterhoeven
2023-12-07 14:09   ` Ulf Hansson
2023-12-06  7:36 ` [PATCH 05/27] tty: core: the rest to u8 Jiri Slaby (SUSE)
2023-12-06  7:36 ` [PATCH 06/27] tty: ami: use u8 for characters and flag Jiri Slaby (SUSE)
2023-12-06  8:28   ` Geert Uytterhoeven
2023-12-06  7:36 ` [PATCH 07/27] tty: bcm: convert to u8 and size_t Jiri Slaby (SUSE)
2023-12-06  7:36 ` [PATCH 08/27] tty: con3215: " Jiri Slaby (SUSE)
2023-12-08 13:19   ` Alexander Gordeev
2023-12-06  7:36 ` [PATCH 09/27] tty: con3270: " Jiri Slaby (SUSE)
2023-12-08 13:19   ` Alexander Gordeev
2023-12-06  7:36 ` [PATCH 10/27] tty: ehv_bytechan: " Jiri Slaby (SUSE)
2023-12-06  7:36 ` [PATCH 11/27] tty: goldfish: " Jiri Slaby (SUSE)
2023-12-06  7:36 ` [PATCH 12/27] tty: hvc: " Jiri Slaby (SUSE)
2023-12-06  9:30   ` Christophe Leroy
2023-12-06  7:36 ` [PATCH 13/27] tty: ipoctal: " Jiri Slaby (SUSE)
2023-12-06  7:36 ` [PATCH 14/27] tty: m68k: nfcon: " Jiri Slaby (SUSE)
2023-12-06  7:51   ` Geert Uytterhoeven
2023-12-06  7:37 ` [PATCH 15/27] tty: mips_ejtag_fdc: use u8 for character pointers Jiri Slaby (SUSE)
2023-12-06  7:37 ` [PATCH 16/27] tty: mmc: sdio: use u8 for flag Jiri Slaby (SUSE)
2023-12-07 14:10   ` Ulf Hansson
2023-12-06  7:37 ` [PATCH 17/27] tty: moxa: convert to u8 and size_t Jiri Slaby (SUSE)
2023-12-06  7:37 ` [PATCH 18/27] tty: mxser: " Jiri Slaby (SUSE)
2023-12-06  7:37 ` Jiri Slaby (SUSE) [this message]
2023-12-06  7:37 ` [PATCH 20/27] tty: n_hdlc: " Jiri Slaby (SUSE)
2023-12-06  7:37 ` [PATCH 21/27] tty: nozomi: " Jiri Slaby (SUSE)
2023-12-07 12:50   ` Ilpo Järvinen
2023-12-06  7:37 ` [PATCH 22/27] tty: serdev: convert to u8 and size_t in serdev_controller_ops Jiri Slaby (SUSE)
2023-12-06  7:37 ` [PATCH 23/27] tty: serdev: convert to u8 and size_t Jiri Slaby (SUSE)
2023-12-06  8:09   ` Johan Hovold
2023-12-07  1:47     ` Greg KH
2023-12-07  8:19       ` Johan Hovold
2023-12-07 10:09         ` Greg KH
2023-12-06  7:37 ` [PATCH 24/27] tty: srmcons: " Jiri Slaby (SUSE)
2023-12-06  7:37 ` [PATCH 25/27] tty: ttyprintk: " Jiri Slaby (SUSE)
2023-12-06  7:37 ` [PATCH 26/27] tty: um: convert to u8/__u8 " Jiri Slaby (SUSE)
2023-12-06  7:37 ` [PATCH 27/27] tty: xtensa/iss: use u8 Jiri Slaby (SUSE)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231206073712.17776-20-jirislaby@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox